[Quantization] Channel-wise Output Activation Quantization for Attention QKV Modules + KV-cache channel quantization #1233
+31
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on : neuralmagic/compressed-tensors#270
SUMMARY:
Quantize the output activation of the attention layers for channel wise -> did not have support -> selected wrong dim to quantize.
Quantize the kv-cache for channel wise int8 -> previously only supported tensor-wise.Next PRAttention we need to worry about is the QKV. O/Up/down is not quantized.
Math:
x is the input vector -> tokenized + embedding
weight for QKV is Linear modules
output is the forward call of QKV with x
Expected output scales and zp shapes for output activations
Expected output scales and zp shapes for kv-cache channel
k_proj, v_proj -> [head_dim]
The observer will output the vectors in the same ndim as the given output activation tensor (ie.
torch.Size([1, 1930, 1024])
, then outputstorch.Size([1, 1, 1024]))
. Squeeze it to just gettorch.Size([1024])
, so ndim of 1.TEST PLAN: