docs: add mermaid modal #288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yuluo-yx
commented
Sep 29, 2025
yuluo-yx
commented
- Fixed docs: optimize the display effect of mermaid image #263
Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>
Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
👥 vLLM Semantic Team NotificationThe following members have been identified for the changed files in this PR and have been automatically assigned: 📁
|
rootfs
reviewed
Sep 29, 2025
rootfs
reviewed
Sep 29, 2025
rootfs
previously approved these changes
Sep 29, 2025
|
@rootfs To be honest, this feature is a bit complicated. The principle is to use React Portal along with some CSS. At present, I have only adjusted mermaid in the system-architecture. I want to recreate a PR and replace all the Mermaid components in the document website with the ZoomableMermaid component. Currently, pr only provides component implementation. WDYT? |
…is enlarged. Signed-off-by: yuluo-yx <yuluo08290126@gmail.com>
Aias00
pushed a commit
to Aias00/semantic-router
that referenced
this pull request
Oct 4, 2025
* docs: add mermaid modal Signed-off-by: yuluo-yx <yuluo08290126@gmail.com> * fix Signed-off-by: yuluo-yx <yuluo08290126@gmail.com> * fix Signed-off-by: yuluo-yx <yuluo08290126@gmail.com> * fix: fix lit Signed-off-by: yuluo-yx <yuluo08290126@gmail.com> * fix Signed-off-by: yuluo-yx <yuluo08290126@gmail.com> * fix Signed-off-by: yuluo-yx <yuluo08290126@gmail.com> * Fix the issue where the top scroll bar is not visible when the chart is enlarged. Signed-off-by: yuluo-yx <yuluo08290126@gmail.com> * fix lint Signed-off-by: yuluo-yx <yuluo08290126@gmail.com> --------- Signed-off-by: yuluo-yx <yuluo08290126@gmail.com> Co-authored-by: Huamin Chen <rootfs@users.noreply.github.com> Signed-off-by: liuhy <liuhongyu@apache.org>
Aias00
pushed a commit
to Aias00/semantic-router
that referenced
this pull request
Oct 4, 2025
* docs: add mermaid modal Signed-off-by: yuluo-yx <yuluo08290126@gmail.com> * fix Signed-off-by: yuluo-yx <yuluo08290126@gmail.com> * fix Signed-off-by: yuluo-yx <yuluo08290126@gmail.com> * fix: fix lit Signed-off-by: yuluo-yx <yuluo08290126@gmail.com> * fix Signed-off-by: yuluo-yx <yuluo08290126@gmail.com> * fix Signed-off-by: yuluo-yx <yuluo08290126@gmail.com> * Fix the issue where the top scroll bar is not visible when the chart is enlarged. Signed-off-by: yuluo-yx <yuluo08290126@gmail.com> * fix lint Signed-off-by: yuluo-yx <yuluo08290126@gmail.com> --------- Signed-off-by: yuluo-yx <yuluo08290126@gmail.com> Co-authored-by: Huamin Chen <rootfs@users.noreply.github.com> Signed-off-by: liuhy <liuhongyu@apache.org>
Aias00
pushed a commit
to Aias00/semantic-router
that referenced
this pull request
Oct 4, 2025
* docs: add mermaid modal Signed-off-by: yuluo-yx <yuluo08290126@gmail.com> * fix Signed-off-by: yuluo-yx <yuluo08290126@gmail.com> * fix Signed-off-by: yuluo-yx <yuluo08290126@gmail.com> * fix: fix lit Signed-off-by: yuluo-yx <yuluo08290126@gmail.com> * fix Signed-off-by: yuluo-yx <yuluo08290126@gmail.com> * fix Signed-off-by: yuluo-yx <yuluo08290126@gmail.com> * Fix the issue where the top scroll bar is not visible when the chart is enlarged. Signed-off-by: yuluo-yx <yuluo08290126@gmail.com> * fix lint Signed-off-by: yuluo-yx <yuluo08290126@gmail.com> --------- Signed-off-by: yuluo-yx <yuluo08290126@gmail.com> Co-authored-by: Huamin Chen <rootfs@users.noreply.github.com> Signed-off-by: liuhy <liuhongyu@apache.org>
yossiovadia
pushed a commit
to yossiovadia/semantic-router
that referenced
this pull request
Oct 8, 2025
* docs: add mermaid modal Signed-off-by: yuluo-yx <yuluo08290126@gmail.com> * fix Signed-off-by: yuluo-yx <yuluo08290126@gmail.com> * fix Signed-off-by: yuluo-yx <yuluo08290126@gmail.com> * fix: fix lit Signed-off-by: yuluo-yx <yuluo08290126@gmail.com> * fix Signed-off-by: yuluo-yx <yuluo08290126@gmail.com> * fix Signed-off-by: yuluo-yx <yuluo08290126@gmail.com> * Fix the issue where the top scroll bar is not visible when the chart is enlarged. Signed-off-by: yuluo-yx <yuluo08290126@gmail.com> * fix lint Signed-off-by: yuluo-yx <yuluo08290126@gmail.com> --------- Signed-off-by: yuluo-yx <yuluo08290126@gmail.com> Co-authored-by: Huamin Chen <rootfs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.