Skip to content

Conversation

@tao12345666333
Copy link
Collaborator

What type of PR is this?

o11y: Add request error counters

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #122

Release Notes: Yes/No

Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@netlify
Copy link

netlify bot commented Sep 14, 2025

Deploy Preview for vllm-semantic-router ready!

Name Link
🔨 Latest commit e54213e
🔍 Latest deploy log https://app.netlify.com/projects/vllm-semantic-router/deploys/68c6da22bb556e000878ea13
😎 Deploy Preview https://deploy-preview-132--vllm-semantic-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

👥 vLLM Semantic Team Notification

The following members have been identified for the changed files in this PR and have been automatically assigned:

📁 src

Owners: @rootfs, @Xunzhuo, @wangchen615
Files changed:

  • src/semantic-router/pkg/extproc/error_metrics_test.go
  • src/semantic-router/pkg/extproc/processor.go
  • src/semantic-router/pkg/extproc/request_handler.go
  • src/semantic-router/pkg/extproc/response_handler.go
  • src/semantic-router/pkg/metrics/metrics.go
  • src/semantic-router/pkg/utils/http/response.go

vLLM

🎉 Thanks for your contributions!

This comment was automatically generated based on the OWNER files in the repository.

[]string{"model"},
)

// RequestErrorsTotal tracks request errors categorized by reason
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add to the doc too in a followup PR? thanks

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! #133

@rootfs rootfs merged commit 88aa203 into vllm-project:main Sep 14, 2025
9 checks passed
@tao12345666333 tao12345666333 deleted the feat-request-error-counters branch September 14, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Metrics: Add request error counters and error-rate computation readiness

4 participants