Skip to content

Conversation

@mrjunwan-lang
Copy link
Collaborator

Description

  1. Update the diagg multi_host script to auto lunch proxy
  2. Delay the p2p_server start to avoid jax device status race condition

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Description

Start with a short description of what the PR does and how this is a change from
the past.

The rest of the description includes relevant details and context, examples:

  • why is this change being made,
  • the problem being solved and any relevant context,
  • why this is a good solution,
  • some information about the specific implementation,
  • shortcomings of the solution and possible future improvements.

If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/123456
FIXES: #123456

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

@mrjunwan-lang mrjunwan-lang merged commit 64693b0 into main Dec 3, 2025
6 checks passed
@mrjunwan-lang mrjunwan-lang deleted the 12-1 branch December 3, 2025 03:42
@jcyang43
Copy link
Collaborator

jcyang43 commented Dec 3, 2025

Hi @mrjunwan-lang, I think this may have broken one of the unit tests (link). Can you PTAL? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants