Skip to content

Commit 1cd27da

Browse files
[Test] Remove VLLM_USE_V1 in accuracy test (#1739)
### What this PR does / why we need it? Remove VLLM_USE_V1 in accuracy test Signed-off-by: hfadzxy <starmoon_zhang@163.com>
1 parent ee40d3d commit 1cd27da

File tree

2 files changed

+4
-9
lines changed

2 files changed

+4
-9
lines changed

.github/workflows/accuracy_test.yaml

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,6 @@ jobs:
9090
}}
9191
strategy:
9292
matrix:
93-
vllm_use_version: [1]
9493
# the accuracy test will run:
9594
# 1. workflow_dispatch with models input
9695
# - all: Qwen/Qwen3-30B-A3B, Qwen/Qwen2.5-VL-7B-Instruct, Qwen/Qwen3-8B-Base
@@ -122,7 +121,7 @@ jobs:
122121
) }}
123122

124123
fail-fast: false
125-
name: ${{ matrix.model_name }} accuracy V${{ matrix.vllm_use_version }}
124+
name: ${{ matrix.model_name }} accuracy
126125
container:
127126
image: m.daocloud.io/quay.io/ascend/cann:8.1.rc1-910b-ubuntu22.04-py3.10
128127
env:
@@ -236,15 +235,14 @@ jobs:
236235
echo "vLLM: ${{ env.GHA_VLLM_VERSION }}"
237236
echo "vLLM Ascend: ${{ env.GHA_VLLM_ASCEND_VERSION }}"
238237
239-
- name: Run Accuracy Test for V${{ matrix.vllm_use_version }}
238+
- name: Run Accuracy Test
240239
id: report
241240
working-directory: ./benchmarks
242241
env:
243242
PYTORCH_NPU_ALLOC_CONF: max_split_size_mb:256
244-
VLLM_USE_V1: ${{ matrix.vllm_use_version }}
245243
run: |
246244
model_base_name=$(basename ${{ matrix.model_name }})
247-
markdown_name="${model_base_name}-V${{ matrix.vllm_use_version }}"
245+
markdown_name="${model_base_name}"
248246
echo "markdown_name=$markdown_name"
249247
echo "markdown_name=$markdown_name" >> $GITHUB_OUTPUT
250248
mkdir -p ./accuracy
@@ -259,7 +257,6 @@ jobs:
259257
--vllm_version "${{ env.GHA_VLLM_VERSION }}" \
260258
--vllm_commit "${{ env.VLLM_COMMIT }}" \
261259
--vllm_ascend_commit "${{ env.VLLM_ASCEND_COMMIT }}" \
262-
--vllm_use_v1 "$VLLM_USE_V1"
263260
264261
- name: Generate step summary
265262
if: ${{ always() }}
@@ -282,7 +279,7 @@ jobs:
282279
echo "contains_fail=false" >> $GITHUB_OUTPUT
283280
fi
284281
285-
- name: Upload Report for V${{ matrix.vllm_use_version }}
282+
- name: Upload Report
286283
if: ${{ github.event_name == 'workflow_dispatch' && steps.check_report.outputs.contains_fail == 'false' }}
287284
uses: actions/upload-artifact@v4
288285
with:

benchmarks/scripts/run_accuracy.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,6 @@ def generate_md(model_name, tasks_list, args, datasets):
168168
**Software Environment**: CANN: {args.cann_version}, PyTorch: {args.torch_version}, torch-npu: {args.torch_npu_version}
169169
**Hardware Environment**: Atlas A2 Series
170170
**Datasets**: {datasets}
171-
**vLLM Engine**: V{args.vllm_use_v1}
172171
**Parallel Mode**: {PARALLEL_MODE[model_name]}
173172
**Execution Mode**: {EXECUTION_MODE[model_name]}
174173
**Command**:
@@ -310,6 +309,5 @@ def main(args):
310309
parser.add_argument("--cann_version", type=str, required=False)
311310
parser.add_argument("--vllm_commit", type=str, required=False)
312311
parser.add_argument("--vllm_ascend_commit", type=str, required=False)
313-
parser.add_argument("--vllm_use_v1", type=str, required=False)
314312
args = parser.parse_args()
315313
main(args)

0 commit comments

Comments
 (0)