Skip to content

Commit 36f4b9e

Browse files
committed
add hang_till_terminated
Signed-off-by: wangli <wangli858794774@gmail.com>
1 parent 46402db commit 36f4b9e

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

tests/e2e/conftest.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,12 @@ def _poll(self) -> Optional[int]:
189189
return self.proc.poll()
190190

191191
def hang_until_terminated(self) -> None:
192-
"""Wait until the server process terminates."""
192+
"""
193+
Wait until the server process terminates.
194+
This is for headless mode, where the api server
195+
process only exits in the leader node.
196+
"""
197+
pass
193198

194199
def _wait_for_server(self, *, url: str, timeout: float):
195200
# run health check

tests/e2e/multi_node/config/multi_node_config.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ def init_dp_param(
7272
) -> None:
7373
self.data_parallel_address = get_net_interface()[0]
7474
if not is_disaggregate_prefill and not is_leader:
75+
# For multi node dp, the workers connect to the leader server.
7576
self.headless = True
7677
self.data_parallel_start_rank = dp_size // world_size
7778
self.data_parallel_address = get_leader_ip()

0 commit comments

Comments
 (0)