Skip to content

Commit a7aed3c

Browse files
committed
[Feat] allow using aclgraph in ray backend
Signed-off-by: WithHades <244036962@qq.com>
1 parent ad13964 commit a7aed3c

File tree

2 files changed

+0
-34
lines changed

2 files changed

+0
-34
lines changed

tests/ut/test_platform.py

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -351,34 +351,6 @@ def test_check_and_update_config_unsupported_cudagraph_mode(
351351
CUDAGraphMode.NONE,
352352
)
353353

354-
@patch("vllm_ascend.utils.is_310p", return_value=False)
355-
@patch("vllm_ascend.ascend_config.check_ascend_config")
356-
@patch("vllm_ascend.ascend_config.init_ascend_config")
357-
def test_check_and_update_config_disable_aclgraph_when_ray_enabled(
358-
self, mock_init_ascend, mock_check_ascend, mock_is_310p):
359-
mock_init_ascend.return_value = self.mock_ascend_config
360-
self.mock_vllm_config.model_config.enforce_eager = False
361-
self.mock_vllm_config.compilation_config.level = CompilationLevel.PIECEWISE
362-
self.mock_vllm_config.parallel_config.distributed_executor_backend = "ray"
363-
364-
with self.assertLogs(logger="vllm", level="WARNING") as cm:
365-
from vllm_ascend import platform
366-
367-
importlib.reload(platform)
368-
self.platform.check_and_update_config(self.mock_vllm_config)
369-
print(30 * "=", f"cm.output: {cm.output}")
370-
self.assertTrue(
371-
"Ray distributed executor backend is not compatible with ACL Graph mode"
372-
in cm.output[0])
373-
self.assertEqual(
374-
self.mock_vllm_config.compilation_config.level,
375-
CompilationLevel.NO_COMPILATION,
376-
)
377-
self.assertEqual(
378-
self.mock_vllm_config.compilation_config.cudagraph_mode,
379-
CUDAGraphMode.NONE,
380-
)
381-
382354
@patch("vllm_ascend.utils.is_310p", return_value=False)
383355
@patch("vllm_ascend.ascend_config.check_ascend_config")
384356
@patch("vllm_ascend.ascend_config.init_ascend_config")

vllm_ascend/platform.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -171,12 +171,6 @@ def check_and_update_config(cls, vllm_config: VllmConfig) -> None:
171171
)
172172
compilation_config.cudagraph_mode = CUDAGraphMode.NONE
173173

174-
if parallel_config.distributed_executor_backend == "ray":
175-
logger.warning(
176-
"Ray distributed executor backend is not compatible with ACL Graph mode "
177-
"right now. Setting CUDAGraphMode to NONE")
178-
compilation_config.cudagraph_mode = CUDAGraphMode.NONE
179-
180174
# set cudaprah sizes before extending `compilation_config.splitting_ops`
181175
vllm_config._set_cudagraph_sizes()
182176

0 commit comments

Comments
 (0)