Skip to content

Commit ac1c2cd

Browse files
authored
[CI] Upgrade vllm version - 0925 (#3167)
Upgrade vLLM to newest commit. 1. Remove the useless func get_state_cls, it has been removed from vLLM already. vllm-project/vllm@e6750d0 2. Fix ut broken by vllm-project/vllm@6160ba4 - vLLM version: v0.10.2 - vLLM main: vllm-project/vllm@b106890 --------- Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
1 parent 33c118c commit ac1c2cd

File tree

7 files changed

+10
-16
lines changed

7 files changed

+10
-16
lines changed

.github/workflows/format_pr_body.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ jobs:
3636

3737
- name: Get vLLM version
3838
run: |
39-
VLLM_COMMIT=b1068903fdca26cf6b4a1a51a32c3365ce3ac636
39+
VLLM_COMMIT=52d0cb845866869d587fc013a7c59e60a86ebcf2
4040
echo "VLLM_COMMIT=https://github.com/vllm-project/vllm/commit/$VLLM_COMMIT" >> $GITHUB_ENV
4141
4242
- name: Checkout repository

.github/workflows/vllm_ascend_test.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ jobs:
4242
lint:
4343
uses: ./.github/workflows/pre-commit.yml
4444
with:
45-
vllm: b1068903fdca26cf6b4a1a51a32c3365ce3ac636
45+
vllm: 52d0cb845866869d587fc013a7c59e60a86ebcf2
4646

4747
changes:
4848
runs-on: ubuntu-latest
@@ -83,7 +83,7 @@ jobs:
8383
VLLM_USE_MODELSCOPE: True
8484
strategy:
8585
matrix:
86-
vllm_version: [b1068903fdca26cf6b4a1a51a32c3365ce3ac636, v0.10.2]
86+
vllm_version: [52d0cb845866869d587fc013a7c59e60a86ebcf2, v0.10.2]
8787
steps:
8888
- name: Install packages
8989
run: |
@@ -138,7 +138,7 @@ jobs:
138138
name: e2e-light
139139
strategy:
140140
matrix:
141-
vllm_version: [b1068903fdca26cf6b4a1a51a32c3365ce3ac636, v0.10.2]
141+
vllm_version: [52d0cb845866869d587fc013a7c59e60a86ebcf2, v0.10.2]
142142
# Note (yikun): If CI resource are limited we can split job into two chain jobs
143143
needs: [lint, changes]
144144
# only trigger e2e test after lint passed and the change is e2e related with pull request.

.github/workflows/vllm_ascend_test_full.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ jobs:
6868
name: e2e-full
6969
strategy:
7070
matrix:
71-
vllm_version: [b1068903fdca26cf6b4a1a51a32c3365ce3ac636, v0.10.2]
71+
vllm_version: [52d0cb845866869d587fc013a7c59e60a86ebcf2, v0.10.2]
7272
needs: [changes]
7373
if: ${{ needs.changes.outputs.e2e_tracker == 'true' }}
7474
uses: ./.github/workflows/_e2e_test.yaml

tests/ut/attention/test_attention_v1.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@
77
AscendAttentionBackendImpl,
88
AscendAttentionMetadataBuilder,
99
AscendAttentionState,
10-
AscendMetadata,
11-
CommonAttentionState)
10+
AscendMetadata)
1211
from vllm_ascend.attention.utils import AscendCommonAttentionMetadata
1312

1413

@@ -25,10 +24,6 @@ def test_get_metadata_cls(self):
2524
self.assertEqual(AscendAttentionBackend.get_metadata_cls(),
2625
AscendMetadata)
2726

28-
def test_get_state_cls(self):
29-
self.assertEqual(AscendAttentionBackend.get_state_cls(),
30-
CommonAttentionState)
31-
3227
def test_get_builder_cls(self):
3328
self.assertEqual(AscendAttentionBackend.get_builder_cls(),
3429
AscendAttentionMetadataBuilder)

tests/ut/ops/test_fused_ops.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -201,6 +201,8 @@ def default_moe_config():
201201
def moe_method(mock_dist_env):
202202
moe = MagicMock()
203203
moe.moe_parallel_config.return_value = MagicMock(ep_size=4)
204+
moe.moe_parallel_config.use_ep = False
205+
moe.moe_parallel_config.dp_size = 1
204206
return AscendUnquantizedFusedMoEMethod(moe)
205207

206208

tests/ut/torchair/ops/test_torchair_fused_moe.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,8 @@ def default_moe_config():
153153
def moe_method(mock_dist_env):
154154
moe = MagicMock()
155155
moe.moe_parallel_config.return_value = MagicMock(ep_size=4)
156+
moe.moe_parallel_config.use_ep = False
157+
moe.moe_parallel_config.dp_size = 1
156158
return TorchairAscendUnquantizedFusedMoEMethod(moe)
157159

158160

vllm_ascend/attention/attention_v1.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
import torch_npu
2525
from vllm.attention.backends.abstract import (AttentionBackend, AttentionImpl,
2626
AttentionLayer, AttentionType)
27-
from vllm.attention.backends.utils import CommonAttentionState
2827
from vllm.config import VllmConfig
2928
from vllm.forward_context import ForwardContext, get_forward_context
3029
from vllm.utils import cdiv, direct_register_custom_op
@@ -56,10 +55,6 @@ def get_impl_cls() -> Type["AscendAttentionBackendImpl"]:
5655
def get_metadata_cls() -> Type["AscendMetadata"]:
5756
return AscendMetadata
5857

59-
@staticmethod
60-
def get_state_cls() -> Type["CommonAttentionState"]:
61-
return CommonAttentionState
62-
6358
@staticmethod
6459
def get_builder_cls() -> type["AscendAttentionMetadataBuilder"]:
6560
return AscendAttentionMetadataBuilder

0 commit comments

Comments
 (0)