fix shell check

Signed-off-by: wangli <wangli858794774@gmail.com>

Author: Potabk

.github/format_pr_body.sh

@@ -1,3 +1,4 @@
+#!/bin/bash
 #
 # Copyright (c) 2025 Huawei Technologies Co., Ltd. All Rights Reserved.
 #
@@ -15,7 +16,6 @@
 # This file is a part of the vllm-ascend project.
 # Adapted from vllm/.github/scripts/cleanup_pr_body.sh
 
-#!/bin/bash
 
 set -eux
 

benchmarks/scripts/run-performance-benchmarks.sh

@@ -25,8 +25,7 @@ ensure_sharegpt_downloaded() {
   if [ ! -f "$FILE" ]; then
     echo "$FILE not found, downloading from hf-mirror ..."
     mkdir -p "$DIR"
-    wget -O "$FILE" https://hf-mirror.com/datasets/anon8231489123/ShareGPT_Vicuna_unfiltered/resolve/main/ShareGPT_V3_unfiltered_cleaned_split.json
-    if [ $? -ne 0 ]; then
+    if ! wget -O "$FILE" https://hf-mirror.com/datasets/anon8231489123/ShareGPT_Vicuna_unfiltered/resolve/main/ShareGPT_V3_unfiltered_cleaned_split.json; then
       echo "Download failed!" >&2
       return 1
     fi

examples/run_dp_attention_etp16_benmark.sh

@@ -6,30 +6,34 @@ rate_array=(0.7)
 
 # Result file
 result_file="benchmark_results.txt"
-echo "Benchmark Results" > $result_file
-echo "===================" >> $result_file
+{
+ echo "Benchmark Results"
+ echo "==================="
+} > $result_file
 
 # Loop through all combinations
 for concurrency in "${concurrency_array[@]}"; do
     for rate in "${rate_array[@]}"; do
         echo "Testing with concurrency=$concurrency, rate=$rate"
-        echo "" >> $result_file
-        echo "Concurrency: $concurrency, Request Rate: $rate" >> $result_file
-        echo "-------------------" >> $result_file
+        {
+         echo ""
+         echo "Concurrency: $concurrency, Request Rate: $rate"
+         echo "-------------------"
+        } >> "$result_file"
 
         # Run benchmark test
         python /mnt/deepseek/vllm/benchmarks/benchmark_serving.py \
             --backend vllm \
             --trust-remote-code \
             --model auto \
-            --tokenizer /mnt/deepseek/DeepSeek-R1-W8A8-VLLM \ 
+            --tokenizer /mnt/deepseek/DeepSeek-R1-W8A8-VLLM \
             --dataset-name random \
             --random-input-len 4096 \
             --random-output-len 1536 \
             --ignore-eos \
             --num-prompts 400 \
-            --max-concurrency $concurrency \
-            --request-rate $rate \
+            --max-concurrency "$concurrency" \
+            --request-rate "$rate" \
             --metric-percentiles 90 \
             --base-url http://localhost:8006 2>&1 | tee -a $result_file
 
@@ -38,15 +42,14 @@ for concurrency in "${concurrency_array[@]}"; do
     done
 done
 
-# Analyze results
-echo "Analysis Results" > analysis_results.txt
-echo "=================" >> analysis_results.txt
-
-# Extract and analyze TPOT data
-echo "TPOT Analysis:" >> analysis_results.txt
-grep "Mean TPOT" $result_file | awk -F':' '{
+{
+  echo "Analysis Results"
+  echo "================="
+  echo "TPOT Analysis:"
+  grep "Mean TPOT" "$result_file" | awk -F':' '{
     printf "Concurrency %s, Rate %s: %s ms\n", $1, $2, $3
-}' >> analysis_results.txt
+  }'
+} > analysis_results.txt
 
 # Extract and analyze throughput data
 echo -e "\nThroughput Analysis:" >> analysis_results.txt

examples/run_dp_server.sh

@@ -27,4 +27,4 @@ vllm serve /data/weights/Qwen2.5-0.5B-Instruct \
     --max-model-len 2000 \
     --max-num-batched-tokens 2000 \
     --trust-remote-code \
-    --gpu-memory-utilization 0.9 \
+    --gpu-memory-utilization 0.9

tests/e2e/common.sh

@@ -68,7 +68,7 @@ function create_vllm_venv() {
 
 function get_version() {
   local VERSION_NAME="$1"
-  python3 "${SCRIPT_DIR}/../../docs/source/conf.py" | jq .${VERSION_NAME} | tr -d '"'
+  python3 "${SCRIPT_DIR}/../../docs/source/conf.py" | jq ."${VERSION_NAME}" | tr -d '"'
 }
 
 SCRIPT_DIR=$(cd "$(dirname "$0")" && pwd)

tests/e2e/pd_disaggreate/setup_pd.sh

@@ -59,10 +59,10 @@ function run_prefill_instance() {
     }')
 
   # start prefill instance
-  ASCEND_RT_VISIBLE_DEVICES=0 vllm serve $model_name \
+  ASCEND_RT_VISIBLE_DEVICES=0 vllm serve "$model_name" \
   --host 0.0.0.0 \
-  --port $prefill_port \
-  --tensor-parallel-size $tp_size \
+  --port "$prefill_port" \
+  --tensor-parallel-size "$tp_size" \
   --served-model-name Deepseek \
   --max-model-len 2000 \
   --trust-remote-code \
@@ -110,10 +110,10 @@ function run_decode_instance() {
     }')
 
   # start decode instance
-  ASCEND_RT_VISIBLE_DEVICES=1 vllm serve $model_name \
+  ASCEND_RT_VISIBLE_DEVICES=1 vllm serve "$model_name" \
     --host 0.0.0.0 \
-    --port $decode_port \
-    --tensor-parallel-size $tp_size \
+    --port "$decode_port" \
+    --tensor-parallel-size "$tp_size" \
     --seed 1024 \
     --served-model-name Deepseek \
     --max-model-len 2000 \

tests/e2e/run_disagg_pd.sh

@@ -19,8 +19,8 @@
 
 set -eo errexit
 
-. $(dirname "$0")/common.sh
-. $(dirname "$0")/pd_disaggreate/setup_pd.sh
+. "$(dirname "$0")/common.sh"
+. "$(dirname "$0")/pd_disaggreate/setup_pd.sh"
 
 export VLLM_USE_MODELSCOPE="True"
 
@@ -30,9 +30,11 @@ TP_SIZE=1
 
 # TODO: support multi-card
 prefill_ip=$(/usr/local/Ascend/driver/tools/hccn_tool -i 0 -ip -g | grep "ipaddr" | awk -F: '{print $2}' | xargs)
+# shellcheck disable=SC2089,SC2090
 PREFILL_DEVICE_IPS="[\"$prefill_ip\"]"
 
 decode_ip=$(/usr/local/Ascend/driver/tools/hccn_tool -i 1 -ip -g | grep "ipaddr" | awk -F: '{print $2}' | xargs)
+# shellcheck disable=SC2089,SC2090
 DECODE_DEVICE_IPS="[\"$decode_ip\"]"
 
 _info "====> Start pd disaggregated test"
@@ -44,14 +46,14 @@ _info "Started pd disaggregated proxy server"
 PREFILL_PROC_NAME="Prefill-instance"
 PREFILL_PORT=8001
 _info "Starting prefill instance"
-run_prefill_instance $MODEL_NAME $TP_SIZE $PREFILL_PORT $REGISTER_PORT $PREFILL_DEVICE_IPS $DECODE_DEVICE_IPS &
+run_prefill_instance $MODEL_NAME $TP_SIZE $PREFILL_PORT $REGISTER_PORT "$PREFILL_DEVICE_IPS" "$DECODE_DEVICE_IPS" &
 _info "Waiting for prefill instance ready"
 wait_url_ready $PREFILL_PROC_NAME "http://localhost:${PREFILL_PORT}/v1/completions"
 
 DECODE_PROC_NAME="Decode-instance"
 DECODE_PORT=8002
 _info "Starting decode instance"
-run_decode_instance  $MODEL_NAME $TP_SIZE $DECODE_PORT $REGISTER_PORT $PREFILL_DEVICE_IPS $DECODE_DEVICE_IPS &
+run_decode_instance  $MODEL_NAME $TP_SIZE $DECODE_PORT $REGISTER_PORT "$PREFILL_DEVICE_IPS" "$DECODE_DEVICE_IPS" &
 _info "Waiting for decode instance ready"
 wait_url_ready $DECODE_PROC_NAME "http://localhost:${DECODE_PORT}/v1/completions"
 

tests/e2e/run_doctests.sh

@@ -19,7 +19,7 @@
 
 set -eo errexit
 
-. $(dirname "$0")/common.sh
+. "$(dirname "$0")/common.sh"
 
 export VLLM_USE_MODELSCOPE=true
 export VLLM_LOGGING_LEVEL=ERROR

tools/mypy.sh

@@ -26,7 +26,7 @@ if [ "$CI" -eq 1 ]; then
     set -e
 fi
 
-if [ $PYTHON_VERSION == "local" ]; then
+if [ "$PYTHON_VERSION" == "local" ]; then
     PYTHON_VERSION=$(python -c 'import sys; print(f"{sys.version_info.major}.{sys.version_info.minor}")')
 fi
 

tools/shellcheck.sh

@@ -40,6 +40,6 @@ if ! [ -x "$(command -v shellcheck)" ]; then
     export PATH
 fi
 
-should enable this
+# should enable this
 find . -path ./.git -prune -o -name "*.sh" -print0 \
-| xargs -0 -I {} sh -c 'git check-ignore -q "{}" || shellcheck -s bash "{}"'
+| xargs -0 -I {} sh -c 'git check-ignore -q "{}" || shellcheck -s bash  -e SC1091 "{}"'