Skip to content

Commit fe7dd05

Browse files
committed
fix review comments
Signed-off-by: Mengqing Cao <cmq0113@163.com>
1 parent ab1e8f8 commit fe7dd05

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

docs/source/user_guide/additional_config.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ The details of each config option are as follows:
5353
| ---- | ---- | ------- | ----------- |
5454
| `enabled` | bool | `False` | Whether to enable ascend scheduler for V1 engine|
5555

56-
ascend_scheduler_config also support the options from [vllm scheduler config](https://docs.vllm.ai/en/stable/api/vllm/config.html#vllm.config.SchedulerConfig). For example, you can add `enable_chunked_prefill: true` to ascend_scheduler_config as well.
56+
ascend_scheduler_config also support the options from [vllm scheduler config](https://docs.vllm.ai/en/stable/api/vllm/config.html#vllm.config.SchedulerConfig). For example, you can add `enable_chunked_prefill: True` to ascend_scheduler_config as well.
5757

5858
### Example
5959

tests/multicard/test_torchair_graph_mode.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,13 @@ def test_e2e_deepseekv3_with_torchair(monkeypatch: pytest.MonkeyPatch):
6060
},
6161
enforce_eager=False,
6262
) as vllm_model:
63+
# use greedy sampler to make sure the generated results are fix
6364
vllm_output = vllm_model.generate_greedy(example_prompts,
6465
max_tokens)
66+
# NOTE: vllm-ascend/DeepSeek-V3-Pruning is a random weight of
67+
# DeepSeek-V3 with 2 hidden layers, thus the golden results seems
68+
# inaccurate. This will only change if accuracy improves with the
69+
# official weights of DeepSeek-V3.
6570
golden_results = [
6671
'Hello, my name is feasibility伸 spazio debtor添',
6772
'The president of the United States is begg"""\n杭州风和 bestimm',

0 commit comments

Comments
 (0)