[CI] Run e2e after pre check pass #1132
Conversation
wangxiyuan
force-pushed
the
e2e_update
branch
2 times, most recently
from
00909c7 to
6571a10
Compare
wangxiyuan
force-pushed
the
e2e_update
branch
2 times, most recently
from
d3d7a71 to
aec9b62
Compare
| run: | ||
| shell: bash -el {0} | ||
|
|
||
| jobs: |
There was a problem hiding this comment.
Could we squash yapf, codespell, ruff into one?
There was a problem hiding this comment.
I think leave mypy test to one is fine as well.
|
@Yikun please take a look again. Merged the 4 lint check into one. https://github.com/vllm-project/vllm-ascend/actions/runs/15552048318?pr=1132 |
There was a problem hiding this comment.
Looks good except comments inline.
BTW, I think we can do some thing pre-commit in future.
https://github.com/vllm-project/vllm/blob/main/.github/workflows/pre-commit.yml
| # | ||
|
|
||
| name: 'e2e test' | ||
| name: 'Basic Test' |
There was a problem hiding this comment.
| name: 'Basic Test' | |
| name: 'test' |
|
|
||
| jobs: | ||
| lint: | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
| runs-on: ubuntu-latest | |
| runs-on: ubuntu-latest | |
| name: lint |
| run: | | ||
| echo "::add-matcher::.github/workflows/matchers/mypy.json" | ||
| tools/mypy.sh 1 ${{ matrix.python-version }} | ||
There was a problem hiding this comment.
Any reason why only actionlint left?
https://github.com/vllm-project/vllm-ascend/blob/main/.github/workflows/actionlint.yml
There was a problem hiding this comment.
let's merge others in the next PR
Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
Make sure the lint test passed before start the e2e test to save compute resource. Updated the patch doc to make sure the CI works as expect. Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
Make sure the lint test passed before start the e2e test to save compute resource. Updated the patch doc to make sure the CI works as expect. Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com> Signed-off-by: wangxiaoxin (A) <wangxiaoxin7@huawei.com>
Make sure the lint test passed before start the e2e test to save compute resource. Updated the patch doc to make sure the CI works as expect. Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com> Signed-off-by: wangxiaoxin (A) <wangxiaoxin7@huawei.com>
Make sure the lint test passed before start the e2e test to save compute resource.
Updated the patch doc to make sure the CI works as expect.