[CI] Add unit test framework #1201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangxiyuan
force-pushed
the
add_ut_framwork
branch
5 times, most recently
from
db86f0d to
1eb66c1
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
wangxiyuan
force-pushed
the
add_ut_framwork
branch
from
1eb66c1 to
a00f80c
Compare
wangxiyuan
force-pushed
the
add_ut_framwork
branch
from
a00f80c to
cc98c5f
Compare
|
After the refactor, the test workflow will be like:
|
wangxiyuan
force-pushed
the
add_ut_framwork
branch
8 times, most recently
from
b463c0a to
860fbb4
Compare
Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
wangxiyuan
force-pushed
the
add_ut_framwork
branch
from
860fbb4 to
5871424
Compare
Yikun
approved these changes
Jun 16, 2025
Yikun
added
ready
shiyuan680
pushed a commit
to raindaywhu/vllm-ascend
that referenced
this pull request
Jul 7, 2025
This PR added the unit test framework to enable ut for vLLM Ascend. Unit test runs on CPU machines. It'll be ran once lint check is passed the same as e2e test. For unit test, this PR created a new folder called `ut` under `tests` module. All the test file in `ut` should keep the same with the code in `vllm-ascend`. The file name should be start with `test_` prefix. For example, in this PR. the `test_ascend_config.py` is added for `ascend_config.py` test. A new fille `worker/test_worker_v1.py` is also added as the placeholder. This file should be the unit test for `vllm-ascend/worker/worker_v1.py`. Additional, a new `fake_weight` folder is added, it contains the config.json from `facebook/opt-125m`, so that the test will not always visit huggingface. TODO: We should add all the unit test file one by one in the future. Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
chopper0126
pushed a commit
to chopper0126/vllm-ascend
that referenced
this pull request
Oct 16, 2025
This PR added the unit test framework to enable ut for vLLM Ascend. Unit test runs on CPU machines. It'll be ran once lint check is passed the same as e2e test. For unit test, this PR created a new folder called `ut` under `tests` module. All the test file in `ut` should keep the same with the code in `vllm-ascend`. The file name should be start with `test_` prefix. For example, in this PR. the `test_ascend_config.py` is added for `ascend_config.py` test. A new fille `worker/test_worker_v1.py` is also added as the placeholder. This file should be the unit test for `vllm-ascend/worker/worker_v1.py`. Additional, a new `fake_weight` folder is added, it contains the config.json from `facebook/opt-125m`, so that the test will not always visit huggingface. TODO: We should add all the unit test file one by one in the future. Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added the unit test framework to enable ut for vLLM Ascend. Unit test runs on CPU machines. It'll be ran once lint check is passed the same as e2e test.
For unit test, this PR created a new folder called
utundertestsmodule. All the test file inutshould keep the same with the code invllm-ascend. The file name should be start withtest_prefix. For example, in this PR. thetest_ascend_config.pyis added forascend_config.pytest.A new fille
worker/test_worker_v1.pyis also added as the placeholder. This file should be the unit test forvllm-ascend/worker/worker_v1.py.Additional, a new
fake_weightfolder is added, it contains the config.json fromfacebook/opt-125m, so that the test will not always visit huggingface.TODO:
We should add all the unit test file one by one in the future.