Skip to content

[Refactor] Refactor torchair #1661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

wangxiyuan
Copy link
Collaborator

@wangxiyuan wangxiyuan commented Jul 8, 2025

Move tochair related code to a new module for better code maintainance

TODO:

  1. mla is still there, since it's only used for deepseek. We can refactor it later.
  2. some ops are still there, we'll find a better way to register the ops with different case.

@wangxiyuan wangxiyuan force-pushed the refactor_torchair branch from ab142d6 to 9d6c8b0 Compare July 8, 2025 02:16
@wangxiyuan wangxiyuan changed the title Refactor torchair [Refactor] Refactor torchair Jul 8, 2025
@wangxiyuan wangxiyuan force-pushed the refactor_torchair branch from 9d6c8b0 to 07890f4 Compare July 8, 2025 02:49
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

Attention: Patch coverage is 93.93939% with 6 lines in your changes missing coverage. Please review.

Project coverage is 54.46%. Comparing base (c30ddb8) to head (c589d9b).
Report is 121 commits behind head on main.

Files with missing lines Patch % Lines
vllm_ascend/torchair/utils.py 92.18% 5 Missing ⚠️
vllm_ascend/platform.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1661       +/-   ##
===========================================
+ Coverage   27.39%   54.46%   +27.06%     
===========================================
  Files          56       81       +25     
  Lines        6191     9921     +3730     
===========================================
+ Hits         1696     5403     +3707     
- Misses       4495     4518       +23     
Flag Coverage Δ
unittests 54.46% <93.93%> (+27.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

github-actions bot commented Jul 9, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@wangxiyuan
Copy link
Collaborator Author

Will createa new one instead.

@wangxiyuan wangxiyuan closed this Jul 14, 2025
@wangxiyuan wangxiyuan deleted the refactor_torchair branch July 15, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant