Skip to content

fix: use dist.reduce_scatter_tensor to avoid memory leak #1688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

NeverRaR
Copy link
Contributor

@NeverRaR NeverRaR commented Jul 9, 2025

What this PR does / why we need it?

fix: use dist.reduce_scatter_tensor to avoid memory leak

Does this PR introduce any user-facing change?

How was this patch tested?

Copy link

codecov bot commented Jul 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 54.47%. Comparing base (c30ddb8) to head (ae879a4).
Report is 107 commits behind head on main.

Files with missing lines Patch % Lines
vllm_ascend/ops/fused_moe.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1688       +/-   ##
===========================================
+ Coverage   27.39%   54.47%   +27.08%     
===========================================
  Files          56       79       +23     
  Lines        6191     9927     +3736     
===========================================
+ Hits         1696     5408     +3712     
- Misses       4495     4519       +24     
Flag Coverage Δ
unittests 54.47% <0.00%> (+27.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NeverRaR NeverRaR force-pushed the fix/reduce_scater_tensor branch from 257b64b to ae879a4 Compare July 9, 2025 08:27
Signed-off-by: boying <897013703@qq.com>
@ApsarasX
Copy link
Collaborator

ApsarasX commented Jul 9, 2025

duplicate of PR #1380

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@NeverRaR NeverRaR closed this Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants