Support pipeline parallel in V1 Engine #1700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1700 +/- ##
===========================================
+ Coverage 27.39% 54.42% +27.02%
===========================================
Files 56 80 +24
Lines 6191 10007 +3816
===========================================
+ Hits 1696 5446 +3750
- Misses 4495 4561 +66
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Yikun
changed the title
|
overall lgtm, please add an e2e test for pp, thanks! |
|
yes, the e2e test should be added at least. A simple one with qwen3-0.6b + PP=2 in multicard is welcome |
wangxiyuan
reviewed
Jul 11, 2025
wangxiyuan
approved these changes
Jul 11, 2025
MengqingCao
reviewed
Jul 11, 2025
| @pytest.mark.parametrize("pp_size", PIPELINE_PARALLELS) | ||
| def test_models(model: str, tp_size: int, pp_size: int) -> None: | ||
| # Create an LLM. | ||
| llm = LLM( |
There was a problem hiding this comment.
I recommand to use tests.conftest.VllmRunner, as we don't need to do the resource clear by hand
Signed-off-by: weiguihua2 <weiguihua2@huawei.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This patch supports pipeline parallel in V1 Engine
Does this PR introduce any user-facing change?
Yes, users can run PP in V1
How was this patch tested?
Manully test