Skip to content

[Test] Remove VLLM_USE_V1 in example and tests #1733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025

Conversation

wangxiyuan
Copy link
Collaborator

@wangxiyuan wangxiyuan commented Jul 11, 2025

V1 is enabled by default, no need to set it by hand now. This PR remove the useless setting in example and tests

@wangxiyuan wangxiyuan force-pushed the remove_v0_in_test branch 4 times, most recently from 9f6cf0d to 51ee9cc Compare July 11, 2025 03:41
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.93%. Comparing base (c30ddb8) to head (67013fb).
Report is 128 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1733       +/-   ##
===========================================
+ Coverage   27.39%   54.93%   +27.53%     
===========================================
  Files          56       80       +24     
  Lines        6191     9712     +3521     
===========================================
+ Hits         1696     5335     +3639     
+ Misses       4495     4377      -118     
Flag Coverage Δ
unittests 54.93% <100.00%> (+27.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wangxiyuan wangxiyuan force-pushed the remove_v0_in_test branch 5 times, most recently from 34dbdfe to d8ba9c4 Compare July 14, 2025 01:52
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@wangxiyuan wangxiyuan force-pushed the remove_v0_in_test branch 2 times, most recently from 754efc9 to bb2261d Compare July 15, 2025 00:31
Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
@wangxiyuan wangxiyuan merged commit 787010a into vllm-project:main Jul 15, 2025
11 of 13 checks passed
@wangxiyuan wangxiyuan deleted the remove_v0_in_test branch July 15, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants