[2/N] Enable shellcheck and pymarkdown for lint system #1735
+290
−138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
Potabk
force-pushed
the
ci_1
branch
2 times, most recently
from
7fe24f7 to
e6fa107
Compare
|
@wangxiyuan @Yikun This is ready for review |
Yikun
approved these changes
Jul 14, 2025
| printf "Concurrency %s, Rate %s: %s ms\n", $1, $2, $3 | ||
| }' >> analysis_results.txt | ||
| }' | ||
| } > analysis_results.txt |
There was a problem hiding this comment.
Suggested change
| } > analysis_results.txt | |
| } >> analysis_results.txt |
?
There was a problem hiding this comment.
this is for shellcheck warning, need compress multiple writes into one to avoid opening files repeatedly
tools/shellcheck.sh
Outdated
| @@ -21,7 +21,7 @@ | |||
|
|
|||
| set -e | |||
|
|
|||
| scversion="stable" | |||
| scversion="v0.10.0" | |||
|
ci break for upstream change, repairing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1735 +/- ##
==========================================
+ Coverage 53.51% 54.22% +0.71%
==========================================
Files 77 75 -2
Lines 9435 9244 -191
==========================================
- Hits 5049 5013 -36
+ Misses 4386 4231 -155
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Should enable python init check after vllm-project/vllm#20908 merged |
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
This reverts commit d1ac979ddc7e7df909fe8d5a22a11f0f252c7b6e. Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Step of #1241, in the pr,
__init__.pycheckDoes this PR introduce any user-facing change?
How was this patch tested?