Skip to content

[Misc] Remove VLLM_USE_V1 usage in code #1764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025

Conversation

wangxiyuan
Copy link
Collaborator

@wangxiyuan wangxiyuan commented Jul 14, 2025

We plan to remove V0 code from this version. The first step is to delete v0 usage.

Related: #1620

@wangxiyuan wangxiyuan changed the title [Misc] Remove VLLM_USE_V1 usage [Misc] Remove VLLM_USE_V1 usage in code Jul 14, 2025
Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

Attention: Patch coverage is 81.48148% with 10 lines in your changes missing coverage. Please review.

Project coverage is 54.20%. Comparing base (c30ddb8) to head (e01ec7d).
Report is 126 commits behind head on main.

Files with missing lines Patch % Lines
vllm_ascend/models/deepseek_dbo.py 0.00% 5 Missing ⚠️
vllm_ascend/models/deepseek_v2.py 0.00% 4 Missing ⚠️
vllm_ascend/platform.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1764       +/-   ##
===========================================
+ Coverage   27.39%   54.20%   +26.81%     
===========================================
  Files          56       82       +26     
  Lines        6191     9995     +3804     
===========================================
+ Hits         1696     5418     +3722     
- Misses       4495     4577       +82     
Flag Coverage Δ
unittests 54.20% <81.48%> (+26.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wangxiyuan wangxiyuan merged commit 7bdada5 into vllm-project:main Jul 15, 2025
22 checks passed
@wangxiyuan wangxiyuan deleted the remove_v1_usage branch July 15, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants