Skip to content

Add UT for Patches #1766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2025
Merged

Conversation

Pr0Wh1teGivee
Copy link
Contributor

@Pr0Wh1teGivee Pr0Wh1teGivee commented Jul 14, 2025

What this PR does / why we need it?

Add UT for patches in vLLM Ascend

Does this PR introduce any user-facing change?

No

How was this patch tested?

Irrelevant

@Pr0Wh1teGivee Pr0Wh1teGivee force-pushed the add_patch_ut branch 5 times, most recently from 03e9597 to a5563a4 Compare July 21, 2025 08:57
@Pr0Wh1teGivee Pr0Wh1teGivee changed the title add patch ut Add UT for Patches Jul 21, 2025
@Pr0Wh1teGivee Pr0Wh1teGivee force-pushed the add_patch_ut branch 3 times, most recently from 36fe57f to 592e5c5 Compare July 21, 2025 10:13
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.41%. Comparing base (9a3bdf2) to head (3173165).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1766      +/-   ##
==========================================
+ Coverage   60.61%   61.41%   +0.79%     
==========================================
  Files          75       77       +2     
  Lines        8127     8264     +137     
==========================================
+ Hits         4926     5075     +149     
+ Misses       3201     3189      -12     
Flag Coverage Δ
unittests 61.41% <100.00%> (+0.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Pr0Wh1teGivee Pr0Wh1teGivee force-pushed the add_patch_ut branch 4 times, most recently from cdf7436 to 57fcc52 Compare July 22, 2025 10:20
@MengqingCao
Copy link
Collaborator

MengqingCao commented Jul 22, 2025

lgtm
P.S. Please update your pr message

@Pr0Wh1teGivee
Copy link
Contributor Author

lgtm P.S. Please update your pr message

Updated

@Pr0Wh1teGivee Pr0Wh1teGivee force-pushed the add_patch_ut branch 2 times, most recently from 6545e87 to ec6afd3 Compare July 23, 2025 03:30
Signed-off-by: Pr0Wh1teGivee <calvin_zhu0210@outlook.com>
@wangxiyuan wangxiyuan merged commit ac773ac into vllm-project:main Jul 23, 2025
14 checks passed
Copy link
Contributor

@yiz-liu yiz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants