-
Notifications
You must be signed in to change notification settings - Fork 466
[CI] Speed up CI by switch to more stable registry #1775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Waiting for all |
Please do a rebase to trigger:
|
768a0f9
to
9a49748
Compare
if: ${{ needs.lint.result == 'success' && (needs.changes.outputs.e2e_tracker == 'true' || needs.changes.outputs.ut_tracker == 'true') }} | ||
runs-on: ubuntu-latest | ||
container: | ||
image: quay.io/ascend/cann:8.1.rc1-910b-ubuntu22.04-py3.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, this shouldn't be changed, it's used github hosted
|
||
container: | ||
image: m.daocloud.io/quay.io/ascend/cann:8.1.rc1-910b-ubuntu22.04-py3.10 | ||
image: swr.cn-southwest-2.myhuaweicloud.com/base_image/ascend-ci/cann:8.1.rc1-910b-ubuntu22.04-py3.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a login required image?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's why the CI failed when you switch runs-on to github hosted runner.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1775 +/- ##
=======================================
Coverage 60.17% 60.17%
=======================================
Files 71 71
Lines 7989 7989
=======================================
Hits 4807 4807
Misses 3182 3182
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
waiting for #1848 to fix the CI |
5fa55b5
to
19744ed
Compare
It seems doctest vllm-ascend image sync not working, the image is pinned to 0716 |
waiting for #1889 |
Signed-off-by: mywaaagh_admin <pkwarcraft@gmail.com>
Signed-off-by: mywaaagh_admin <pkwarcraft@gmail.com>
19744ed
to
fb23a8c
Compare
main image is as expected, but v0.9.1-dev image is still out of date |
see #1912 |
What this PR does / why we need it?
More discussion can be found here.
The infra team deployed a internal registry since both
m.daocloud.io
andquay.io
suffered a unstable connect quality.CI will benefit both the connection and download speed by switching to the internal registry.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
tested locally