Skip to content

Conversation

pkking
Copy link
Contributor

@pkking pkking commented Jul 14, 2025

What this PR does / why we need it?

More discussion can be found here.

The infra team deployed a internal registry since both m.daocloud.io and quay.io suffered a unstable connect quality.

CI will benefit both the connection and download speed by switching to the internal registry.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

tested locally

@pkking
Copy link
Contributor Author

pkking commented Jul 15, 2025

Waiting for all vllm-ascend images were synced to SWR

@Yikun
Copy link
Collaborator

Yikun commented Jul 17, 2025

Please do a rebase to trigger:

- '.github/workflows/vllm_ascend_test.yaml'

@pkking pkking force-pushed the use_mirror_images branch from 768a0f9 to 9a49748 Compare July 17, 2025 01:33
if: ${{ needs.lint.result == 'success' && (needs.changes.outputs.e2e_tracker == 'true' || needs.changes.outputs.ut_tracker == 'true') }}
runs-on: ubuntu-latest
container:
image: quay.io/ascend/cann:8.1.rc1-910b-ubuntu22.04-py3.10
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, this shouldn't be changed, it's used github hosted

@Yikun
Copy link
Collaborator

Yikun commented Jul 17, 2025

BTW, why still cost 1m 54s in 2nd times container run?

image


container:
image: m.daocloud.io/quay.io/ascend/cann:8.1.rc1-910b-ubuntu22.04-py3.10
image: swr.cn-southwest-2.myhuaweicloud.com/base_image/ascend-ci/cann:8.1.rc1-910b-ubuntu22.04-py3.10
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a login required image?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's why the CI failed when you switch runs-on to github hosted runner.

Copy link

codecov bot commented Jul 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.17%. Comparing base (8cfd257) to head (fb23a8c).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1775   +/-   ##
=======================================
  Coverage   60.17%   60.17%           
=======================================
  Files          71       71           
  Lines        7989     7989           
=======================================
  Hits         4807     4807           
  Misses       3182     3182           
Flag Coverage Δ
unittests 60.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pkking pkking closed this Jul 17, 2025
@pkking pkking reopened this Jul 17, 2025
@pkking
Copy link
Contributor Author

pkking commented Jul 17, 2025

waiting for #1848 to fix the CI

@pkking pkking force-pushed the use_mirror_images branch from 5fa55b5 to 19744ed Compare July 17, 2025 13:03
@Yikun Yikun added performance-test enable performance test for PR accuracy-test enable all accuracy test for PR ready-for-test start test by label for PR labels Jul 17, 2025
@Yikun
Copy link
Collaborator

Yikun commented Jul 18, 2025

It seems doctest vllm-ascend image sync not working, the image is pinned to 0716

@pkking pkking closed this Jul 18, 2025
@pkking pkking reopened this Jul 18, 2025
@pkking pkking closed this Jul 18, 2025
@pkking pkking reopened this Jul 18, 2025
@pkking pkking closed this Jul 19, 2025
@pkking pkking reopened this Jul 19, 2025
@pkking pkking closed this Jul 19, 2025
@pkking pkking reopened this Jul 19, 2025
@pkking pkking closed this Jul 19, 2025
@pkking pkking reopened this Jul 19, 2025
@pkking
Copy link
Contributor Author

pkking commented Jul 19, 2025

waiting for #1889

@pkking pkking closed this Jul 20, 2025
@pkking pkking reopened this Jul 20, 2025
@pkking pkking closed this Jul 21, 2025
@pkking pkking reopened this Jul 21, 2025
pkking added 3 commits July 21, 2025 10:34
Signed-off-by: mywaaagh_admin <pkwarcraft@gmail.com>
Signed-off-by: mywaaagh_admin <pkwarcraft@gmail.com>
Signed-off-by: mywaaagh_admin <pkwarcraft@gmail.com>
@pkking pkking force-pushed the use_mirror_images branch from 19744ed to fb23a8c Compare July 21, 2025 02:35
@Yikun
Copy link
Collaborator

Yikun commented Jul 21, 2025

main image is as expected, but v0.9.1-dev image is still out of date

@pkking pkking closed this Jul 21, 2025
@pkking
Copy link
Contributor Author

pkking commented Jul 21, 2025

see #1912

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accuracy-test enable all accuracy test for PR performance-test enable performance test for PR ready-for-test start test by label for PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants