[Feature] Optimize forward metadata collection across dp ranks #1857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1857 +/- ##
=======================================
Coverage 54.80% 54.80%
=======================================
Files 75 75
Lines 9327 9327
=======================================
Hits 5112 5112
Misses 4215 4215
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Rebase here: f9dfde0 |
jianzs
force-pushed
the
feat/dp-comm-opt
branch
2 times, most recently
from
7b605f8 to
2b0c3c1
Compare
ApsarasX
approved these changes
Jul 18, 2025
wangxiyuan
reviewed
Jul 19, 2025
vllm_ascend/worker/worker_v1.py
Outdated
| if runner.dp_size > 1: | ||
| max_num_tokens, with_prefill = runner._get_forward_metadata_across_dp( | ||
| max_num_tokens, with_prefill) | ||
| if runner.dp_size <= 1: |
There was a problem hiding this comment.
Let's do the torchair refactor fist. Then add related code there #1885
There was a problem hiding this comment.
What are your plans for the model_runner refactoring?
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Jade Zheng <zheng.shoujian@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resubmit #1593
What this PR does / why we need it?
This PR introduces two optimizations for cases where data parallel size > 1:
set_forward_contextDoes this PR introduce any user-facing change?
no
How was this patch tested?
CI passed.