-
Notifications
You must be signed in to change notification settings - Fork 270
[CI]Add e2e test for 310p #1879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
14c173e
to
8fd9102
Compare
8fd9102
to
c567f9c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1879 +/- ##
==========================================
+ Coverage 60.17% 60.21% +0.03%
==========================================
Files 71 71
Lines 7989 7997 +8
==========================================
+ Hits 4807 4815 +8
Misses 3182 3182
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c567f9c
to
a240a5e
Compare
a240a5e
to
4bd1674
Compare
4bd1674
to
3b3ac11
Compare
3b3ac11
to
eed48ec
Compare
4bc42e5
to
9a22d24
Compare
LGTM if CI passed |
@@ -0,0 +1,51 @@ | |||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not create a new forder. change to something like:
tests/e2e/singlecard/test_offiline_inference_310p.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# This file is a part of the vllm-ascend project. | ||
# Adapted from vllm/tests/basic_correctness/test_basic_correctness.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useless 2 lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
# | ||
"""Compare the short outputs of the Pangu (Ascend) model when using greedy sampling. | ||
|
||
Run `pytest tests/e2e/test_offline_inference.py`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete it
1420ed6
to
67309fd
Compare
Signed-off-by: hfadzxy <starmoon_zhang@163.com>
67309fd
to
63e626f
Compare
What this PR does / why we need it?
Add e2e test for 310p
Does this PR introduce any user-facing change?
How was this patch tested?