Skip to content

[CI] Make AttentionBackend interface compatible to fix broken CI #1893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2025

Conversation

wangxiyuan
Copy link
Collaborator

@wangxiyuan wangxiyuan commented Jul 20, 2025

vLLM commit vllm-project/vllm@752c6ad removed blocksparse_params for attention backend. This PR does the same change to make CI happy.

@Yikun Yikun changed the title [CI] Fix broken CI [CI] Make AttentionBackend interface compatible to fix broken CI Jul 20, 2025
Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
Copy link

codecov bot commented Jul 20, 2025

Codecov Report

Attention: Patch coverage is 64.70588% with 6 lines in your changes missing coverage. Please review.

Project coverage is 60.88%. Comparing base (2b726d8) to head (0407ffc).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
vllm_ascend/attention/mla_v1.py 57.14% 3 Missing ⚠️
vllm_ascend/attention/attention_v1.py 60.00% 2 Missing ⚠️
tests/ut/attention/test_attention_v1.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1893      +/-   ##
==========================================
- Coverage   60.89%   60.88%   -0.01%     
==========================================
  Files          73       73              
  Lines        8157     8171      +14     
==========================================
+ Hits         4967     4975       +8     
- Misses       3190     3196       +6     
Flag Coverage Δ
unittests 60.88% <64.70%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wangxiyuan wangxiyuan force-pushed the fix_ci_0720 branch 2 times, most recently from a72dcaa to 64c5c4c Compare July 20, 2025 14:06
Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
@Yikun Yikun merged commit a8b316a into vllm-project:main Jul 21, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants