[3/N][Refactor] Move torchair_attention to torchair dir
#2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1 similar comment
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
8 tasks
shen-shanshan
changed the title
shen-shanshan
changed the title
shen-shanshan
changed the title
torchair_attention to torchair dir
shen-shanshan
changed the title
torchair_attention to torchair dirtorchair_attention to torchair dir
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
shen-shanshan
added
ready-for-test
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2017 +/- ##
=======================================
Coverage ? 76.18%
=======================================
Files ? 120
Lines ? 13532
Branches ? 0
=======================================
Hits ? 10310
Misses ? 3222
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shen-shanshan
force-pushed
the
air-2
branch
3 times, most recently
from
24235b4 to
dadc66e
Compare
wangxiyuan
approved these changes
Aug 15, 2025
wangxiyuan
approved these changes
Aug 19, 2025
wangxiaoteng888
pushed a commit
to LCAIZJ/vllm-ascend
that referenced
this pull request
Sep 25, 2025
…ject#2017) ### What this PR does / why we need it? 1. Move `torchair_attention` to `torchair` dir. 2. Make `AscendAttentionTorchairBackend` extend `AscendAttentionBackend` to reduce duplicate methods. 3. Make `AscendTorchairMetadata` extend `AscendMetadata` to reduce duplicate properties. ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? - vLLM version: v0.10.0 - vLLM main: vllm-project/vllm@0933f9d --------- Signed-off-by: shen-shanshan <467638484@qq.com>
chopper0126
pushed a commit
to chopper0126/vllm-ascend
that referenced
this pull request
Sep 26, 2025
…ject#2017) ### What this PR does / why we need it? 1. Move `torchair_attention` to `torchair` dir. 2. Make `AscendAttentionTorchairBackend` extend `AscendAttentionBackend` to reduce duplicate methods. 3. Make `AscendTorchairMetadata` extend `AscendMetadata` to reduce duplicate properties. ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? - vLLM version: v0.10.0 - vLLM main: vllm-project/vllm@0933f9d --------- Signed-off-by: shen-shanshan <467638484@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
torchair_attentiontotorchairdir.AscendAttentionTorchairBackendextendAscendAttentionBackendto reduce duplicate methods.AscendTorchairMetadataextendAscendMetadatato reduce duplicate properties.Does this PR introduce any user-facing change?
How was this patch tested?