-
Notifications
You must be signed in to change notification settings - Fork 484
[Misc] Add warning for incompatible Ray backend with ACL Graph mode #2132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
Please rename title and commits msg more meaningful. |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if CI passed
Signed-off-by: 22dimensions <waitingwind@foxmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2132 +/- ##
==========================================
+ Coverage 74.41% 75.03% +0.62%
==========================================
Files 100 103 +3
Lines 11208 11358 +150
==========================================
+ Hits 8340 8523 +183
+ Misses 2868 2835 -33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…llm-project#2132) ### What this PR does / why we need it? cherry-pick vllm-project#1501 from 0.9.1-dev to main Currently, Ray is not compatible with ACL Graph, so we need to fall back to eager mode when using the Ray backend. co-authored: Yizhou Liu <liu_yizhou@outlook.com> - vLLM version: v0.10.0 - vLLM main: vllm-project/vllm@2836dd7 Signed-off-by: 22dimensions <waitingwind@foxmail.com>
What this PR does / why we need it?
cherry-pick #1501 from 0.9.1-dev to main
Currently, Ray is not compatible with ACL Graph, so we need to fall back to eager mode when using the Ray backend.
co-authored: Yizhou Liu liu_yizhou@outlook.com
Does this PR introduce any user-facing change?
How was this patch tested?