Skip to content

[Image] Upgrade to 24.03 #2628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Image] Upgrade to 24.03 #2628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile.openEuler
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
# This file is a part of the vllm-ascend project.
#

FROM quay.io/ascend/cann:8.2.rc1-910b-openeuler22.03-py3.11
FROM quay.io/ascend/cann:8.2.rc1-910b-openeuler24.03-py3.11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This update to openeuler24.03 is only applied to this Dockerfile. Other Dockerfiles in the project, such as Dockerfile.310p.openEuler and Dockerfile.a3.openEuler, still use openeuler22.03. This creates an inconsistent environment across different build targets, which can lead to subtle bugs and increased maintenance overhead. It is strongly recommended to update all related Dockerfiles to use the same base OS version for consistency.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gemini-code-assist this change is just for test. I'll update all the related file once the test works

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the clarification. It's understandable to make such changes for testing purposes. Please ensure that all relevant Dockerfiles are updated for consistency once your testing is complete and the change is ready for final integration. This will help maintain a stable and predictable environment across the project.


ARG PIP_INDEX_URL="https://mirrors.tuna.tsinghua.edu.cn/pypi/web/simple"
ARG COMPILE_CUSTOM_KERNELS=1
Expand Down
Loading