-
Notifications
You must be signed in to change notification settings - Fork 483
[0.9.1][PromptLogprobs][V1] Support prompt logprobs to fix ceval accuracy in V1 #2654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wangxiyuan
merged 2 commits into
vllm-project:v0.9.1-dev
from
MengqingCao:prompt_logprobs
Sep 7, 2025
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current implementation computes logits for each request serially within a
for
loop by callingself.model.compute_logits
on sliced hidden states. This approach can become a significant performance bottleneck, especially in evaluation scenarios where many requests might require prompt logprobs simultaneously.While the comment on line 2337 mentions prioritizing simplicity, the performance degradation from unbatched calls on the accelerator can be substantial.
I recommend refactoring this to batch the logit computation across all requests that need it. A possible approach is:
prompt_hidden_states
slices.torch.cat
.model.compute_logits
call on the concatenated tensor.This change would leverage the NPU's parallel processing capabilities more effectively and significantly improve performance.