fix ascend fused moe spelling error #2863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhaozixin <zhaozixin1@huawei.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request contains a spelling correction for the routed_scaling_factor parameter in vllm_ascend/ops/common_fused_moe.py. The change is applied consistently in the __init__ method of the AscendFusedMoE class, both in its signature and the call to the superclass constructor. This resolves a potential runtime error.
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
wangxiyuan
approved these changes
Sep 11, 2025
yiz-liu
pushed a commit
to linfeng-yuan/vllm-ascend
that referenced
this pull request
Sep 12, 2025
### What this PR does / why we need it? fix ascend fused moe spelling error ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? vllm-project/vllm@0ae43db - vLLM version: main - vLLM main: vllm-project/vllm@fcc0a31 Signed-off-by: zhaozixin <zhaozixin1@huawei.com> Co-authored-by: zhaozixin <zhaozixin1@huawei.com> Signed-off-by: Yizhou Liu <liu_yizhou@outlook.com>
offline893
pushed a commit
to offline893/vllm-ascend
that referenced
this pull request
Sep 16, 2025
### What this PR does / why we need it? fix ascend fused moe spelling error ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? vllm-project/vllm@0ae43db - vLLM version: main - vLLM main: vllm-project/vllm@fcc0a31 Signed-off-by: zhaozixin <zhaozixin1@huawei.com> Co-authored-by: zhaozixin <zhaozixin1@huawei.com> Signed-off-by: offline0806 <z00858301@china.huawei.com>
wangxiaoteng888
pushed a commit
to LCAIZJ/vllm-ascend
that referenced
this pull request
Sep 25, 2025
### What this PR does / why we need it? fix ascend fused moe spelling error ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? vllm-project/vllm@0ae43db - vLLM version: main - vLLM main: vllm-project/vllm@fcc0a31 Signed-off-by: zhaozixin <zhaozixin1@huawei.com> Co-authored-by: zhaozixin <zhaozixin1@huawei.com>
chopper0126
pushed a commit
to chopper0126/vllm-ascend
that referenced
this pull request
Sep 26, 2025
### What this PR does / why we need it? fix ascend fused moe spelling error ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? vllm-project/vllm@0ae43db - vLLM version: main - vLLM main: vllm-project/vllm@fcc0a31 Signed-off-by: zhaozixin <zhaozixin1@huawei.com> Co-authored-by: zhaozixin <zhaozixin1@huawei.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
fix ascend fused moe spelling error
Does this PR introduce any user-facing change?
How was this patch tested?
vllm-project/vllm@0ae43db