Skip to content

Conversation

Yikun
Copy link
Collaborator

@Yikun Yikun commented Sep 12, 2025

What this PR does / why we need it?

This reverts commit 7b2ecc1.

Does this PR introduce any user-facing change?

No

How was this patch tested?

CI passed

Closes: #2890
Closes: #2887
Closes: #2885

Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

This reverts commit 7b2ecc1.

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
@Yikun Yikun added accuracy-test enable all accuracy test for PR ready read for review ready-for-test start test by label for PR labels Sep 12, 2025
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.89%. Comparing base (1bbb20e) to head (cea2888).
⚠️ Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2896      +/-   ##
==========================================
+ Coverage   74.76%   74.89%   +0.12%     
==========================================
  Files         150      154       +4     
  Lines       20891    21241     +350     
==========================================
+ Hits        15620    15908     +288     
- Misses       5271     5333      +62     
Flag Coverage Δ
unittests 74.89% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Yikun Yikun marked this pull request as ready for review September 12, 2025 12:41
@wangxiyuan wangxiyuan merged commit 756b8a1 into vllm-project:main Sep 12, 2025
64 checks passed
offline893 pushed a commit to offline893/vllm-ascend that referenced this pull request Sep 16, 2025
…lm-project#2896)

### What this PR does / why we need it?
This reverts commit 7b2ecc1.

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
CI passed

- vLLM version: main
- vLLM main:
vllm-project/vllm@64d90c3

Closes: vllm-project#2890
Closes: vllm-project#2887
Closes: vllm-project#2885

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Signed-off-by: offline0806 <z00858301@china.huawei.com>
wangxiaoteng888 pushed a commit to LCAIZJ/vllm-ascend that referenced this pull request Sep 25, 2025
…lm-project#2896)

### What this PR does / why we need it?
This reverts commit 7b2ecc1.

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
CI passed

- vLLM version: main
- vLLM main:
vllm-project/vllm@64d90c3

Closes: vllm-project#2890
Closes: vllm-project#2887
Closes: vllm-project#2885

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
chopper0126 pushed a commit to chopper0126/vllm-ascend that referenced this pull request Sep 26, 2025
…lm-project#2896)

### What this PR does / why we need it?
This reverts commit 7b2ecc1.

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
CI passed

- vLLM version: main
- vLLM main:
vllm-project/vllm@64d90c3

Closes: vllm-project#2890
Closes: vllm-project#2887
Closes: vllm-project#2885

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accuracy-test enable all accuracy test for PR module:ops module:quantization module:tests ready read for review ready-for-test start test by label for PR
Projects
None yet
2 participants