Skip to content

Conversation

wlf-darkmatter
Copy link

@wlf-darkmatter wlf-darkmatter commented Sep 13, 2025

What this PR does / why we need it?

Fix the conflict between pyproject.toml with requirement.txt and requirements-dev.txt.

related to #2835

Does this PR introduce any user-facing change?

How was this patch tested?

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 13, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to synchronize dependency files. The changes correctly move pytest_mock to requirements-dev.txt and update the torch-npu version in the README files. However, there are a couple of outstanding issues. First, requirements-dev.txt contains a duplicate ray dependency (on lines 8 and 14), which should be consolidated. Second, while the READMEs are updated, other documentation files like docs/source/installation.md still reference the old torch-npu version constraint (>= 2.5.1.post1). Addressing these points would make the dependency management more robust and consistent across the project.

transformers<4.53.0
pytest_mock
networkx

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This trailing blank line, and others in the file, can cause issues during installation. The current parsing logic in setup.py for requirements.txt is brittle and interprets blank lines as empty-string dependencies, which will likely cause pip to fail during installation. Please remove all trailing blank lines from this file. For a more robust long-term fix, consider improving the requirement parsing logic in setup.py to explicitly ignore blank lines.

@tardis-key
Copy link

Thank you! LGTM!
#2835

@tardis-key
Copy link

@Yikun hi, please review

Signed-off-by: WangLingfeng <wlf_x_contion@sina.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants