Skip to content

fix pyproject.toml confict with requirement.txt and requirements-dev.txt #2908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v0.9.1-dev
Choose a base branch
from
+5 −5
Open

fix pyproject.toml confict with requirement.txt and requirements-dev.txt #2908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ By using vLLM Ascend plugin, popular open-source models, including Transformer-l
- Software:
* Python >= 3.9, < 3.12
* CANN >= 8.2.RC1
* PyTorch >= 2.5.1, torch-npu >= 2.5.1.post1
* PyTorch >= 2.5.1, torch-npu == 2.5.1.post1
* vLLM (the same version as vllm-ascend)

## Getting Started
Expand Down
2 changes: 1 addition & 1 deletion README.zh.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ vLLM 昇腾插件 (`vllm-ascend`) 是一个由社区维护的让vLLM在Ascend NP
- 软件：
* Python >= 3.9, < 3.12
* CANN >= 8.2.RC1
* PyTorch >= 2.5.1, torch-npu >= 2.5.1.post1
* PyTorch >= 2.5.1, torch-npu == 2.5.1.post1
* vLLM (与vllm-ascend版本一致)

## 开始使用
Expand Down
3 changes: 2 additions & 1 deletion requirements-dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ types-jsonschema
xgrammar
zmq
types-psutil
networkx

ray>=2.47.1
protobuf>3.20.0
pytest_mock
3 changes: 1 addition & 2 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,4 @@ torch-npu==2.5.1.post1

# Remove after https://github.com/vllm-project/vllm-ascend/issues/1470
transformers<4.53.0
pytest_mock
networkx

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This trailing blank line, and others in the file, can cause issues during installation. The current parsing logic in setup.py for requirements.txt is brittle and interprets blank lines as empty-string dependencies, which will likely cause pip to fail during installation. Please remove all trailing blank lines from this file. For a more robust long-term fix, consider improving the requirement parsing logic in setup.py to explicitly ignore blank lines.