Revert "Upgrade CANN version to 8.3.rc1.alpha001 (#2903)" #2909
Conversation
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
github-actions
bot
added
the
documentation
This reverts commit 339fceb. Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reverts the CANN version from 8.3.rc1.alpha001 back to 8.2.rc1 across various Dockerfiles and documentation files. The changes appear to correctly revert the previous commit. My review focuses on ensuring consistency in the updated version strings. I've found a minor inconsistency in the casing of rc1/RC1 in the documentation files and have provided suggestions to align them for better clarity and consistency.
| - Software: | ||
| * Python >= 3.9, < 3.12 | ||
| * CANN >= 8.3.rc1.alpha001 (Ascend HDK version refers to [here](https://www.hiascend.com/document/detail/zh/canncommercial/82RC1/releasenote/releasenote_0000.html)) | ||
| * CANN >= 8.2.rc1 (Ascend HDK version refers to [here](https://www.hiascend.com/document/detail/zh/canncommercial/82RC1/releasenote/releasenote_0000.html)) |
There was a problem hiding this comment.
For consistency with the linked Ascend documentation URL (which uses 82RC1) and docs/source/installation.md (which uses 8.2.RC1), it's recommended to use uppercase RC1 here. This will prevent potential confusion for users comparing version numbers across different documents.
| * CANN >= 8.2.rc1 (Ascend HDK version refers to [here](https://www.hiascend.com/document/detail/zh/canncommercial/82RC1/releasenote/releasenote_0000.html)) | |
| * CANN >= 8.2.RC1 (Ascend HDK version refers to [here](https://www.hiascend.com/document/detail/zh/canncommercial/82RC1/releasenote/releasenote_0000.html)) |
| - 软件： | ||
| * Python >= 3.9, < 3.12 | ||
| * CANN >= 8.3.rc1.alpha001 (Ascend HDK 版本参考[这里](https://www.hiascend.com/document/detail/zh/canncommercial/82RC1/releasenote/releasenote_0000.html)) | ||
| * CANN >= 8.2.rc1 (Ascend HDK 版本参考[这里](https://www.hiascend.com/document/detail/zh/canncommercial/82RC1/releasenote/releasenote_0000.html)) |
There was a problem hiding this comment.
For consistency with the linked Ascend documentation URL (which uses 82RC1) and docs/source/installation.md (which uses 8.2.RC1), it's recommended to use uppercase RC1 here. This will prevent potential confusion for users comparing version numbers across different documents.
| * CANN >= 8.2.rc1 (Ascend HDK 版本参考[这里](https://www.hiascend.com/document/detail/zh/canncommercial/82RC1/releasenote/releasenote_0000.html)) | |
| * CANN >= 8.2.RC1 (Ascend HDK 版本参考[这里](https://www.hiascend.com/document/detail/zh/canncommercial/82RC1/releasenote/releasenote_0000.html)) |
|
Just a revert, so let's merge this quickly, if basic and lint ci passed |
|
…vllm-project#2909) ### What this PR does / why we need it? This reverts commit 339fceb. ### Does this PR introduce _any_ user-facing change? Yes, use 8.2rc1 image by default ### How was this patch tested? CI passed - vLLM version: v0.10.2rc2 - vLLM main: vllm-project/vllm@cfa3234 Signed-off-by: Yikun Jiang <yikunkero@gmail.com> Signed-off-by: offline0806 <z00858301@china.huawei.com>
…vllm-project#2909) ### What this PR does / why we need it? This reverts commit 339fceb. ### Does this PR introduce _any_ user-facing change? Yes, use 8.2rc1 image by default ### How was this patch tested? CI passed - vLLM version: v0.10.2rc2 - vLLM main: vllm-project/vllm@cfa3234 Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
…vllm-project#2909) ### What this PR does / why we need it? This reverts commit 339fceb. ### Does this PR introduce _any_ user-facing change? Yes, use 8.2rc1 image by default ### How was this patch tested? CI passed - vLLM version: v0.10.2rc2 - vLLM main: vllm-project/vllm@cfa3234 Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
What this PR does / why we need it?
This reverts commit 339fceb.
Does this PR introduce any user-facing change?
Yes, use 8.2rc1 image by default
How was this patch tested?
CI passed