Skip to content

Conversation

Yikun
Copy link
Collaborator

@Yikun Yikun commented Sep 13, 2025

What this PR does / why we need it?

Bump vLLM version to v0.10.2rc3
vllm-project/vllm@v0.10.2rc2...v0.10.2rc3

Does this PR introduce any user-facing change?

No

How was this patch tested?

CI passed

Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 13, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the vLLM version to v0.10.2rc3 and downgrades the CANN version to 8.2.rc1 across various Dockerfiles and documentation files. The changes are mostly consistent. However, I've pointed out an issue in docs/source/conf.py where several version variables used for documentation generation were not updated, which could lead to user confusion. Please address this to ensure the documentation is aligned with the code changes.

'cann_image_tag': "8.2.rc1-910b-ubuntu22.04-py3.11",
# vllm version in ci
'ci_vllm_version': 'v0.10.2rc2',
'ci_vllm_version': 'v0.10.2rc3',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While ci_vllm_version is correctly updated to v0.10.2rc3, several other version-related variables in the myst_substitutions dictionary are outdated. This will cause the installation documentation to point to older versions of vllm and vllm-ascend, which is inconsistent with the changes in this PR and will likely confuse users trying to build from source or install from pip.

Please update the related versions for consistency. For example:

    'vllm_version': 'v0.10.2rc3',
    'vllm_ascend_version': 'v0.10.2rc3', # Or the corresponding vllm-ascend tag for this change
    'pip_vllm_ascend_version': "0.10.2rc3", # Or the corresponding vllm-ascend tag for this change
    'pip_vllm_version': "0.10.2rc3",

This will ensure that the documentation for building from source and installing from pip reflects the new version.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, we shouldn't upgrade here

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
@Yikun Yikun added ready read for review accuracy-test enable all accuracy test for PR ready-for-test start test by label for PR labels Sep 13, 2025
@wangxiyuan wangxiyuan merged commit f97a64b into vllm-project:main Sep 13, 2025
59 of 63 checks passed
offline893 pushed a commit to offline893/vllm-ascend that referenced this pull request Sep 16, 2025
### What this PR does / why we need it?
Bump vLLM version to v0.10.2rc3
vllm-project/vllm@v0.10.2rc2...v0.10.2rc3

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
CI passed

- vLLM version: v0.10.2rc2
- vLLM main:
vllm-project/vllm@15b8fef

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Signed-off-by: offline0806 <z00858301@china.huawei.com>
wangxiaoteng888 pushed a commit to LCAIZJ/vllm-ascend that referenced this pull request Sep 25, 2025
### What this PR does / why we need it?
Bump vLLM version to v0.10.2rc3
vllm-project/vllm@v0.10.2rc2...v0.10.2rc3

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
CI passed

- vLLM version: v0.10.2rc2
- vLLM main:
vllm-project/vllm@15b8fef

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
chopper0126 pushed a commit to chopper0126/vllm-ascend that referenced this pull request Sep 26, 2025
### What this PR does / why we need it?
Bump vLLM version to v0.10.2rc3
vllm-project/vllm@v0.10.2rc2...v0.10.2rc3

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
CI passed

- vLLM version: v0.10.2rc2
- vLLM main:
vllm-project/vllm@15b8fef

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accuracy-test enable all accuracy test for PR documentation Improvements or additions to documentation ready read for review ready-for-test start test by label for PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants