-
Notifications
You must be signed in to change notification settings - Fork 461
Bump vLLM version to v0.10.2rc3 #2911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the vLLM version to v0.10.2rc3
and downgrades the CANN version to 8.2.rc1
across various Dockerfiles and documentation files. The changes are mostly consistent. However, I've pointed out an issue in docs/source/conf.py
where several version variables used for documentation generation were not updated, which could lead to user confusion. Please address this to ensure the documentation is aligned with the code changes.
'cann_image_tag': "8.2.rc1-910b-ubuntu22.04-py3.11", | ||
# vllm version in ci | ||
'ci_vllm_version': 'v0.10.2rc2', | ||
'ci_vllm_version': 'v0.10.2rc3', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While ci_vllm_version
is correctly updated to v0.10.2rc3
, several other version-related variables in the myst_substitutions
dictionary are outdated. This will cause the installation documentation to point to older versions of vllm
and vllm-ascend
, which is inconsistent with the changes in this PR and will likely confuse users trying to build from source or install from pip.
Please update the related versions for consistency. For example:
'vllm_version': 'v0.10.2rc3',
'vllm_ascend_version': 'v0.10.2rc3', # Or the corresponding vllm-ascend tag for this change
'pip_vllm_ascend_version': "0.10.2rc3", # Or the corresponding vllm-ascend tag for this change
'pip_vllm_version': "0.10.2rc3",
This will ensure that the documentation for building from source and installing from pip reflects the new version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, we shouldn't upgrade here
Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
### What this PR does / why we need it? Bump vLLM version to v0.10.2rc3 vllm-project/vllm@v0.10.2rc2...v0.10.2rc3 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI passed - vLLM version: v0.10.2rc2 - vLLM main: vllm-project/vllm@15b8fef Signed-off-by: Yikun Jiang <yikunkero@gmail.com> Signed-off-by: offline0806 <z00858301@china.huawei.com>
### What this PR does / why we need it? Bump vLLM version to v0.10.2rc3 vllm-project/vllm@v0.10.2rc2...v0.10.2rc3 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI passed - vLLM version: v0.10.2rc2 - vLLM main: vllm-project/vllm@15b8fef Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
### What this PR does / why we need it? Bump vLLM version to v0.10.2rc3 vllm-project/vllm@v0.10.2rc2...v0.10.2rc3 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI passed - vLLM version: v0.10.2rc2 - vLLM main: vllm-project/vllm@15b8fef Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
What this PR does / why we need it?
Bump vLLM version to v0.10.2rc3
vllm-project/vllm@v0.10.2rc2...v0.10.2rc3
Does this PR introduce any user-facing change?
No
How was this patch tested?
CI passed