Skip to content

apply_top_k_top_p_tpu #2928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

apply_top_k_top_p_tpu #2928

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed2cc0c
apply_top_k_top_p_tpu
AlvisGong Sep 15, 2025
98d5c43
apply_top_k_top_p_tpu
AlvisGong Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions vllm_ascend/sample/sampler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import torch
import torch_npu
from vllm.config import LogprobsMode
from vllm.v1.sample.ops.topk_topp_sampler import TopKTopPSampler, random_sample
from vllm.v1.sample.ops.topk_topp_sampler import TopKTopPSampler, random_sample, apply_top_k_top_p_tpu
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from vllm.v1.sample.ops.topk_topp_sampler import TopKTopPSampler, random_sample, apply_top_k_top_p_tpu
from vllm.v1.sample.tpu.sampler import apply_top_k_top_p as apply_top_k_top_p_tpu

from vllm.v1.sample.sampler import Sampler

from vllm_ascend.utils import is_310p
Expand Down Expand Up @@ -63,7 +63,7 @@ def _apply_top_k_top_p(

def forward_native(self, logits, generators, k, p):
"""Override pytorch native implementation to torch_npu"""
logits = self._apply_top_k_top_p(logits, k, p)
logits = apply_top_k_top_p_tpu(logits, k, p)
logits_to_return = None
if self.logprobs_mode == LogprobsMode.PROCESSED_LOGITS:
logits_to_return = logits
Expand Down
Loading