Skip to content

Conversation

Yikun
Copy link
Collaborator

@Yikun Yikun commented Sep 20, 2025

Potabk and others added 30 commits September 19, 2025 20:29
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: MengqingCao <cmq0113@163.com>
Signed-off-by: MengqingCao <cmq0113@163.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: MengqingCao <cmq0113@163.com>
Signed-off-by: MengqingCao <cmq0113@163.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: MengqingCao <cmq0113@163.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: MengqingCao <cmq0113@163.com>
Signed-off-by: MengqingCao <cmq0113@163.com>
Signed-off-by: MengqingCao <cmq0113@163.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Potabk and others added 5 commits September 19, 2025 21:04
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: wangli <wangli858794774@gmail.com>
Signed-off-by: MengqingCao <cmq0113@163.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@Yikun Yikun added the ready read for review label Sep 20, 2025
@Yikun Yikun added ready-for-test start test by label for PR ready read for review and removed ready-for-test start test by label for PR labels Sep 20, 2025
@Yikun Yikun force-pushed the pr/2907 branch 3 times, most recently from 29f8246 to 74cc40d Compare September 20, 2025 06:24
Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Copy link

codecov bot commented Sep 20, 2025

Codecov Report

❌ Patch coverage is 13.01370% with 127 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.95%. Comparing base (1bbb20e) to head (71c9711).
⚠️ Report is 79 commits behind head on main.

Files with missing lines Patch % Lines
vllm_ascend/worker/model_runner_v1.py 3.38% 114 Missing ⚠️
vllm_ascend/worker/npu_input_batch.py 58.33% 5 Missing ⚠️
vllm_ascend/spec_decode/mtp_proposer.py 0.00% 3 Missing ⚠️
tests/ut/ops/test_fused_ops.py 50.00% 1 Missing ⚠️
tests/ut/torchair/ops/test_torchair_fused_moe.py 50.00% 1 Missing ⚠️
vllm_ascend/ops/fused_moe.py 66.66% 1 Missing ⚠️
vllm_ascend/platform.py 66.66% 1 Missing ⚠️
vllm_ascend/torchair/ops/torchair_fused_moe.py 66.66% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (13.01%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3057      +/-   ##
==========================================
- Coverage   74.76%   71.95%   -2.82%     
==========================================
  Files         150      168      +18     
  Lines       20891    23547    +2656     
==========================================
+ Hits        15620    16943    +1323     
- Misses       5271     6604    +1333     
Flag Coverage Δ
unittests 71.95% <13.01%> (-2.82%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added merge-conflicts and removed ready read for review labels Sep 20, 2025
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants