Skip to content

Conversation

linfeng-yuan
Copy link
Collaborator

@linfeng-yuan linfeng-yuan commented Sep 21, 2025

What this PR does / why we need it?

Does this PR introduce any user-facing change?

How was this patch tested?

Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to introduce support for customized hccl_buffer_size during process group initialization. While the intent is clear, the current implementation contains several critical errors, including missing imports, syntax errors, and incorrect function calls. These issues will prevent the code from running and must be addressed. I have provided specific feedback on each issue to help resolve them.

@linfeng-yuan linfeng-yuan force-pushed the support_customized_hccl_buffer_size_for_hccl_pg branch 2 times, most recently from 1cb5c8c to 342d249 Compare September 22, 2025 07:04
…group initialization

Signed-off-by: linfeng-yuan <1102311262@qq.com>
@linfeng-yuan linfeng-yuan force-pushed the support_customized_hccl_buffer_size_for_hccl_pg branch from 342d249 to 4f06ec0 Compare September 22, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant