Skip to content

Conversation

wangxiyuan
Copy link
Collaborator

@wangxiyuan wangxiyuan commented Sep 22, 2025

  1. remove useless function vanilla_chunked_prefill_mla, vanilla_decode_mla, causal_conv1d_update_ref and rms_norm_ref
  2. move expert_load_balancer to eplb module
  3. move fla, casual_conv1d and sigmoid_gating to triton module

Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a good refactoring effort that improves the project structure by moving modules to more logical locations and removing apparently unused functions. The changes are consistent with the description, leading to a cleaner codebase. However, I've identified a critical issue in vllm_ascend/ops/__init__.py where significant changes to the package's public API are made by removing several imports and the __all__ definition. These changes could break other parts of the codebase or downstream consumers and are not documented in the pull request. Please address this to ensure the stability of the package's API.

@wangxiyuan wangxiyuan force-pushed the refactor_ops branch 2 times, most recently from a977d7d to 13b2b76 Compare September 22, 2025 03:21
Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant