Skip to content

Conversation

paulyu12
Copy link
Collaborator

@paulyu12 paulyu12 commented Sep 22, 2025

What this PR does / why we need it?

Fix the impact to LoRA that vllm-project/vllm#25249 brought.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

pytest -sv tests/e2e/singlecard/test_ilama_lora.py
pytest -sv tests/e2e/multicard/test_ilama_lora_tp2.py

Signed-off-by: paulyu12 <507435917@qq.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a bug in LoRA model loading by updating the arguments for the load_lora_model method. The change aligns the call with a recent upstream modification in vLLM, correctly passing the vllm_config object instead of multiple individual configuration objects. This is a necessary fix for compatibility and improves code clarity. The change is correct and I see no issues.

@Yikun Yikun added ready read for review ready-for-test start test by label for PR labels Sep 22, 2025
@Yikun
Copy link
Collaborator

Yikun commented Sep 22, 2025

Thanks for your contributions! See above comments to address ci failure

Signed-off-by: paulyu12 <507435917@qq.com>
Signed-off-by: paulyu12 <507435917@qq.com>
@wangxiyuan wangxiyuan merged commit 704467c into vllm-project:main Sep 22, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready read for review ready-for-test start test by label for PR vllm-break
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants