Skip to content

Conversation

yiz-liu
Copy link
Collaborator

@yiz-liu yiz-liu commented Sep 22, 2025

What this PR does / why we need it?

Updates the cudagraph_support attribute to aclgraph_support to use terminology appropriate for the Ascend platform (ACL graphs instead of CUDA graphs).

This change also explicitly disables graph support for the MLA attention backend.

Does this PR introduce any user-facing change?

None.

How was this patch tested?

None needed.

Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@yiz-liu yiz-liu changed the title refactor: Rename cudagraph_support to aclgraph_support [Refactor] Rename cudagraph_support to aclgraph_support Sep 22, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the cudagraph_support attribute to aclgraph_support for better naming consistency on the Ascend platform. It also explicitly disables graph support for the MLA attention backend. The changes are straightforward, consistent, and correctly implemented across the affected files. The code modifications look good and I have no further comments.

Updates the `cudagraph_support` attribute to `aclgraph_support` to use terminology appropriate for the Ascend platform (ACL graphs instead of CUDA graphs).

This change also explicitly disables graph support for the MLA attention backend.

Signed-off-by: Yizhou Liu <liu_yizhou@outlook.com>
@Potabk Potabk added ready read for review ready-for-test start test by label for PR labels Sep 23, 2025
@wangxiyuan wangxiyuan merged commit 39a85c4 into vllm-project:main Sep 23, 2025
48 checks passed
@yiz-liu yiz-liu deleted the fix-mla branch September 23, 2025 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready read for review ready-for-test start test by label for PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants