-
Notifications
You must be signed in to change notification settings - Fork 460
Fix VLLM_ASCEND_LLMDD_RPC_PORT renaming #3108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix VLLM_ASCEND_LLMDD_RPC_PORT renaming #3108
Conversation
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
Signed-off-by: wyu0-0 <woshilynn@163.com>
c9ecea6
to
a0739c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly renames the environment variable VLLM_LLMDD_RPC_PORT
to VLLM_ASCEND_LLMDD_RPC_PORT
in an example and a test script, which aligns with the goal of improving naming consistency. While the renaming is correct, I've pointed out a high-severity maintainability issue in tests/e2e/pd_disaggreate/run_edge_case_test.sh
. The script redefines the BASE_CMD
variable, which is an error-prone practice. I've recommended using unique variable names for the prefill and decode commands to make the script more robust and easier to maintain.
PREFILL_PORT=8001 | ||
|
||
BASE_CMD="ASCEND_RT_VISIBLE_DEVICES=0 VLLM_LLMDD_RPC_PORT=5559 vllm serve $model_name \ | ||
BASE_CMD="ASCEND_RT_VISIBLE_DEVICES=0 VLLM_ASCEND_LLMDD_RPC_PORT=5559 vllm serve $model_name \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable BASE_CMD
is defined here and then redefined on line 93 for the decode instance. This pattern of reusing and redefining variables is error-prone and can make the script difficult to maintain. To improve clarity and prevent potential bugs, I recommend using a unique name for this command, such as PREFILL_BASE_CMD
.
|
||
# Build the command with or without model-specific args | ||
BASE_CMD="ASCEND_RT_VISIBLE_DEVICES=1 VLLM_LLMDD_RPC_PORT=6000 vllm serve $model_name \ | ||
BASE_CMD="ASCEND_RT_VISIBLE_DEVICES=1 VLLM_ASCEND_LLMDD_RPC_PORT=6000 vllm serve $model_name \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line redefines the BASE_CMD
variable, which was first assigned on line 73. Reusing variable names this way can lead to confusion and makes the script fragile. A better practice is to use a distinct variable name for the decode command, like DECODE_BASE_CMD
, to make the script's logic clearer and more robust against future changes.
What this PR does / why we need it?
This PR implements the renaming of the environment variable VLLM_LLMDD_RPC_PORT to VLLM_ASCEND_LLMDD_RPC_PORT, as proposed and tracked in #2450. The renaming is intended to align the variable naming convention with other Ascend-specific environment variables in the vllm-ascend codebase, enhancing consistency and clarity for developers and users working with Ascend-based deployments.
Does this PR introduce any user-facing change?
NA
How was this patch tested?
CI passed with existing test.