Skip to content

Conversation

@liziyu179
Copy link
Contributor

@liziyu179 liziyu179 commented Oct 25, 2025

What this PR does / why we need it?

force with_prefill true after allreduce in kv producer

Does this PR introduce any user-facing change?

How was this patch tested?

Signed-off-by: liziyu <liziyu16@huawei.com>
@liziyu179 liziyu179 changed the title force with_prefill true after allreduce in kv producer [P/D] force with_prefill true after allreduce in kv producer Oct 25, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly moves the logic for forcing with_prefill = True on KV producer nodes to be executed before the _sync_metadata_across_dp call. This change is crucial as it ensures that the with_prefill state is consistently synchronized across all data-parallel ranks. By doing so, it prevents potential deadlocks or correctness issues that could arise from inconsistent states during distributed dummy runs. The modification is a clean and effective fix for a critical distributed logic issue.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Signed-off-by: liziyu <liziyu16@huawei.com>
Copy link
Collaborator

@yiz-liu yiz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove this with_prefill = True once attn_state is refactored or removed.

@yiz-liu yiz-liu added ready read for review ready-for-test start test by label for PR labels Oct 28, 2025
@linfeng-yuan
Copy link
Collaborator

LGTM. It doesn't affect torchair scenario since we always expect with_prefill to be True for P node.

@MengqingCao MengqingCao merged commit c76db62 into vllm-project:main Oct 29, 2025
47 of 48 checks passed
MengqingCao pushed a commit that referenced this pull request Oct 29, 2025
#3835)

### What this PR does / why we need it?
force with_prefill true after allreduce in kv producer. This is a backport of #3768 and #3849

---------

Signed-off-by: liziyu <liziyu16@huawei.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready read for review ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants