-
Notifications
You must be signed in to change notification settings - Fork 551
[P/D] force with_prefill true after allreduce in kv producer #3768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[P/D] force with_prefill true after allreduce in kv producer #3768
Conversation
Signed-off-by: liziyu <liziyu16@huawei.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly moves the logic for forcing with_prefill = True on KV producer nodes to be executed before the _sync_metadata_across_dp call. This change is crucial as it ensures that the with_prefill state is consistently synchronized across all data-parallel ranks. By doing so, it prevents potential deadlocks or correctness issues that could arise from inconsistent states during distributed dummy runs. The modification is a clean and effective fix for a critical distributed logic issue.
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
Signed-off-by: liziyu <liziyu16@huawei.com>
yiz-liu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove this with_prefill = True once attn_state is refactored or removed.
|
LGTM. It doesn't affect torchair scenario since we always expect |
What this PR does / why we need it?
force with_prefill true after allreduce in kv producer
Does this PR introduce any user-facing change?
How was this patch tested?