-
Notifications
You must be signed in to change notification settings - Fork 544
[WIP] Upgrade to 0.11.1 newest vllm commit #3982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to upgrade the vLLM dependency to version 0.11.1. The changes primarily involve adapting to new import paths in the upstream library. However, the implementation of the version checks is not robust, using exact version matching which can lead to import errors with other vLLM versions. I have provided critical feedback and suggestions to fix this issue across multiple files. The rest of the changes appear to be correct for this upgrade.
f52b902 to
c1e61fb
Compare
Signed-off-by: 22dimensions <waitingwind@foxmail.com>
What this PR does / why we need it?
adapt vllm-ascend main branch with vllm releases/v0.11.1
Does this PR introduce any user-facing change?
No
How was this patch tested?
CI