Skip to content

Conversation

@22dimensions
Copy link
Collaborator

@22dimensions 22dimensions commented Nov 4, 2025

What this PR does / why we need it?

adapt vllm-ascend main branch with vllm releases/v0.11.1

Does this PR introduce any user-facing change?

No

How was this patch tested?

CI

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to upgrade the vLLM dependency to version 0.11.1. The changes primarily involve adapting to new import paths in the upstream library. However, the implementation of the version checks is not robust, using exact version matching which can lead to import errors with other vLLM versions. I have provided critical feedback and suggestions to fix this issue across multiple files. The rest of the changes appear to be correct for this upgrade.

@22dimensions 22dimensions force-pushed the update branch 3 times, most recently from f52b902 to c1e61fb Compare November 5, 2025 09:39
Signed-off-by: 22dimensions <waitingwind@foxmail.com>
@MengqingCao MengqingCao added ready read for review ready-for-test start test by label for PR labels Nov 6, 2025
Signed-off-by: 22dimensions <waitingwind@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:tests ready read for review ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants