Skip to content

Conversation

@lilinsiman
Copy link
Contributor

@lilinsiman lilinsiman commented Nov 6, 2025

What this PR does / why we need it?

add new ut case for aclgraph in auto enable

Does this PR introduce any user-facing change?

no

How was this patch tested?

ut

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new unit test to verify the behavior of aclgraph auto-enabling. The test case is relevant and covers an important configuration path. My review includes one suggestion to improve the robustness of the test by making the log assertion less fragile, which will improve its long-term maintainability.

Comment on lines 44 to 47
self.assertTrue(
"PIECEWISE compilation enabled on NPU. use_inductor not supported - "
"using only ACL Graph mode" in
cm.output[1])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Checking for a log message at a specific index cm.output[1] makes the test fragile. If other log messages are added or their order changes in the future, this test will break unexpectedly. It's more robust to check if the expected message exists anywhere in the log output, rather than relying on its exact position.

Suggested change
self.assertTrue(
"PIECEWISE compilation enabled on NPU. use_inductor not supported - "
"using only ACL Graph mode" in
cm.output[1])
self.assertTrue(any(
"PIECEWISE compilation enabled on NPU. use_inductor not supported - "
"using only ACL Graph mode" in message
for message in cm.output), "Expected log message not found.")

@lilinsiman lilinsiman force-pushed the ut branch 3 times, most recently from cb93d3b to be30ff3 Compare November 6, 2025 09:56
Signed-off-by: lilinsiman <lilinsiman@gmail.com>
@yiz-liu yiz-liu added ready read for review ready-for-test start test by label for PR and removed ready read for review ready-for-test start test by label for PR labels Nov 6, 2025
@linfeng-yuan linfeng-yuan added ready-for-test start test by label for PR ready read for review and removed ready-for-test start test by label for PR ready read for review labels Nov 7, 2025
@yiz-liu yiz-liu added ready-for-test start test by label for PR and removed ready-for-test start test by label for PR labels Nov 7, 2025
@wangxiyuan wangxiyuan removed the ready-for-test start test by label for PR label Nov 7, 2025
@wangxiyuan wangxiyuan merged commit 22286fc into vllm-project:main Nov 7, 2025
93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:tests ready read for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants