Skip to content

Conversation

Yikun
Copy link
Collaborator

@Yikun Yikun commented Apr 29, 2025

What this PR does / why we need it?

Add quickstart doctest

Does this PR introduce any user-facing change?

no

How was this patch tested?

@Yikun Yikun force-pushed the doctest branch 4 times, most recently from 36ae9f8 to d2d2c86 Compare April 29, 2025 23:10
@Yikun
Copy link
Collaborator Author

Yikun commented Apr 29, 2025

image
# PWD: /__w/vllm-ascend/vllm-ascend
if [ ! -d /workspace/vllm-ascend/tests/doctest ]; then
  echo "Warning: the doctest path doesn't exists, copy now"
  cp -r tests/doctest /workspace/vllm-ascend/tests/
fi
cd /workspace
./vllm-ascend/tests/doctest/run_tests.sh
Info: ====> Start Quickstart test
Info: ====> Start simple_test
Traceback (most recent call last):
  File "<string>", line 1, in <module>
AttributeError: module 'vllm' has no attribute '__version__'

The test results are as expected: https://github.com/vllm-project/vllm-ascend/actions/runs/14743092958/job/41385215566?pr=730

@Yikun Yikun force-pushed the doctest branch 8 times, most recently from e67092c to 480ea84 Compare May 1, 2025 00:52
@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 1, 2025
@Yikun Yikun force-pushed the doctest branch 2 times, most recently from 9b07353 to cf6e629 Compare May 1, 2025 01:15
@Yikun
Copy link
Collaborator Author

Yikun commented May 1, 2025

The CI will be failed as expected, because the infra image are using default imagePullPolicy: if you omit the imagePullPolicy field, and you specify the tag for the container image that isn't :latest, the imagePullPolicy is automatically set to IfNotPresent.

Offline discuss with @pkking , the infra imagePullPolicy should be changed to Always: every time the kubelet launches a container, the kubelet queries the container image registry to resolve the name to an image [digest](https://docs.docker.com/engine/reference/commandline/pull/#pull-an-image-by-digest-immutable-identifier). If the kubelet has a container image with that exact digest cached locally, the kubelet uses its cached image; otherwise, the kubelet pulls the image with the resolved digest, and uses that image to launch the container.

[1] https://kubernetes.io/docs/concepts/containers/images/#imagepullpolicy-defaulting
[2] https://kubernetes.io/docs/concepts/containers/images/#image-pull-policy

(update 0501) Discuss with @ppking, we can use ENV_HOOK_TEMPLATE_PATH to enable podTemplate to set image policy in infra.

@Yikun Yikun force-pushed the doctest branch 3 times, most recently from cc31721 to a0e5c23 Compare May 7, 2025 01:11
@wangxiyuan
Copy link
Collaborator

ready for review now?

@Yikun Yikun marked this pull request as ready for review May 11, 2025 03:07
@Yikun
Copy link
Collaborator Author

Yikun commented May 11, 2025

ready for review now?

Yes, it‘s ready, pls help to review, I will take a final look and merge it after your +1.

@Yikun Yikun force-pushed the doctest branch 4 times, most recently from b34706b to 34978b1 Compare May 13, 2025 13:29
@Yikun Yikun changed the title Add quickstart doctest Add e2e test frame work and doctest May 13, 2025
@Yikun Yikun force-pushed the doctest branch 2 times, most recently from 74f5e0a to 27181ea Compare May 13, 2025 14:14
Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
@wangxiyuan wangxiyuan merged commit 59e0250 into vllm-project:main May 14, 2025
11 checks passed
@Yikun Yikun mentioned this pull request May 14, 2025
83 tasks
Yikun added a commit that referenced this pull request Jun 9, 2025
### What this PR does / why we need it?
As plus of #1070, this
patch adds `Nominating and Removing Maintainers` section (reference some
design from [PyTorch
Governance](https://docs.pytorch.org/docs/stable/community/governance.html))

Below are key info about existing maintainers:

## @wangxiyuan: 
- Super active code and high quality reviewer [450+ PR
reviewed](https://github.com/vllm-project/vllm-ascend/pulls?q=commenter%3Awangxiyuan).
- One of the top contributors, he also active contribute [50+ commits
](https://github.com/vllm-project/vllm-ascend/pulls?q=is%3Apr+is%3Aclosed+review%3Aapproved+author%3Awangxiyuan+)
with good quality, he dares to [refactor the
code](https://github.com/vllm-project/vllm-ascend/pulls?q=is%3Apr+author%3Awangxiyuan+is%3Aclosed+refactor),
which also shows his deep understanding of vllm and vllm ascend.
- He leads the [[RFC]: Hardware
pluggable](vllm-project/vllm#11162) feature,
this make vllm-ascend project become true.
- Active community involved cross wechat group, slack, github issue.
Involved on [150+
issue](https://github.com/vllm-project/vllm-ascend/issues?q=is%3Aissue%20state%3Aopen%20commenter%3Awangxiyuan)
and help users. He is also the spearker of vLLM Beijing meetup help more
users understand vLLM Ascend.
- Relase manager of
[v0.7.1rc1](https://github.com/vllm-project/vllm-ascend/releases/tag/v0.7.1rc1),
[v0.7.3rc1](https://github.com/vllm-project/vllm-ascend/releases/tag/v0.7.3rc1),
[v0.7.3rc2](https://github.com/vllm-project/vllm-ascend/releases/tag/v0.7.3rc2),
[v0.8.4rc1](https://github.com/vllm-project/vllm-ascend/releases/tag/v0.8.4rc1),
[v0.7.3.post1](https://github.com/vllm-project/vllm-ascend/releases/tag/v0.7.3.post1).

## @Yikun: 
- High active code reviewer: [190+ PR
reviewed](https://github.com/vllm-project/vllm-ascend/pulls?q=commenter%3AYikun),
especially for new developers to help them onboarding.
- One of the top contributors with sustained contributions: [50+
commits](https://github.com/vllm-project/vllm-ascend/pulls?q=is%3Apr+is%3Aclosed+review%3Aapproved+author%3AYikun+)
since the first day of vLLM Ascend.
- High quality contributions around vLLM compatibility guarantee and
also maintain [CI
](#1040) and [test
Framework](#730).
- Active community involved cross local group, github issue Involved on
[170+
issue](https://github.com/vllm-project/vllm-ascend/issues?q=is%3Aissue%20state%3Aopen%20commenter%3AYikun).
He is also main organizer of vLLM Beijing Meetup and speaker of [PyTorch
Day China
2025](https://pytorchdaychina2025.sched.com/event/2401V/poster-session)
to help vLLM Ascend growth.
- Relase manager of
[v0.8.4rc2](https://github.com/vllm-project/vllm-ascend/releases/tag/v0.8.4rc2),
[v0.8.5rc1](https://github.com/vllm-project/vllm-ascend/releases/tag/v0.8.5rc1),
[v0.7.3](https://github.com/vllm-project/vllm-ascend/releases/tag/v0.7.3).

## @ganyi1996ppo 
- High active code and high quality reviewer: [90+ PR
reviewed](https://github.com/vllm-project/vllm-ascend/pulls?q=commenter%3Aganyi1996ppo),
he has a deep understanding of Ascend operators can always find some key
issues, has deeply understand of the codebase, good code quality and
qualified judgement.
- Major and high quality contributions: [10+
commits](https://github.com/vllm-project/vllm-ascend/pulls?q=is%3Apr+is%3Aclosed+review%3Aapproved+author%3Aganyi1996ppo)
with high quality.
- He is the main contributor of [Custom AscendC op
support](#371),
[Deepseekv3 performance
optimization](#598).
- Community Involvement‌: Involved on [11+ issue and help
users](https://github.com/vllm-project/vllm-ascend/issues?q=is%3Aissue%20state%3Aopen%20commenter%3Aganyi1996ppo),
share [custom ops
topic](https://www.bilibili.com/video/BV1Z25az3EqS/?share_source=copy_web&vd_source=72ef9c665af5f2f1370abe26ce1f719f&t=1342)
on vLLM Ascend Weekly meeting.


### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Preview

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation module:tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants