Apply suggestions from code review

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Author: luccafong

vllm/config.py

@@ -4017,11 +4017,9 @@ def _compile_regex_patterns(self):
                 compiled_pattern: Pattern[str] = re.compile(regex_pattern)
                 self._compiled_module_calls[compiled_pattern] = call_idx
                 logger.info(f"Successfully compiled regex pattern: '{regex_pattern}'")
-            except re.error as e:
-                logger.error(f"Invalid regex pattern from '{regex_pattern_call_idx}': {e}")
-                raise ValueError(f"Invalid regex pattern '{regex_pattern_call_idx}': {e}")
             except Exception as e:
-                logger.error(f"Failed to parse module_call_match")
+                logger.error(f"Failed to parse module_call_match '{regex_pattern_call_idx}': {e}")
+                raise ValueError(f"Failed to parse module_call_match '{regex_pattern_call_idx}': {e}") from e
 
 
         logger.info(f"Compiled {len(self._compiled_module_calls)} regex patterns")

vllm/v1/worker/intermediates_logging.py

@@ -197,8 +197,7 @@ def convert_intermediates_to_json(tensor: Any) -> Any:
 
                     # Add statistics
                     try:
-                        result["values_min"] = float(tensor_cpu.min().item()) if tensor_cpu.numel() > 0 else None
-                    except:
+                    except Exception:
                         result["values_min"] = "error"
 
                     try:

vllm/v1/worker/worker_base.py

@@ -85,5 +85,4 @@ def register_intermediate_hooks(self,
             register_intermediate_hooks(model, config, **kwargs)
             # Store the logger instance for potential later hook removal
             logger.info("Successfully registered intermediate hooks")
-        except Exception as e:
-            logger.error(f"Error registering intermediate hooks", e)
+            logger.error("Error registering intermediate hooks", exc_info=True)