-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[Bugfix] Fix Hermes tool call parser with streaming #18220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Bugfix] Fix Hermes tool call parser with streaming #18220
Conversation
…f integers Signed-off-by: johngerving <gervingjohn@gmail.com>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you write a test case for this? Thanks
I stumbled into this as well.
I'd be happy to collaborate with this. Are there examples of other similar tests that I can use as a guide? |
Is this going to be merged soon? |
Fixes an issue where the first argument returned from a function call is not parsed properly by
hermes_tool_parser.py
when the type of the argument is not a string. This caused the delta of an integer argument to be cut off in the final delta returned to the client, eventually causing the entire first argument of the tool call to be missing.FIX #18108