Skip to content

[WIP][EPLB] Enable Llama4 EPLB #20792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

b8zhong
Copy link
Contributor

@b8zhong b8zhong commented Jul 11, 2025

Purpose

As a part of #20468, support EPLB for Llama4

Test Plan

WIP,

Test Result

vllm serve /models/Llama4-Scout-17B --tensor-parallel-size 8 --enable-eplb
vllm serve /fp8-llama/llama4scout-fp8/ \
  --tensor-parallel-size 8 \
  --max-model-len 2048 \
  --enable-expert-parallel \
  --enable-eplb \
  --num-redundant-experts 16 \
  --eplb-window-size 1000 \
  --eplb-step-interval 3000 \
  --trust-remote-code \
  --enforce-eager

WIP

(Optional) Documentation Update

WIP

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the llama Related to Llama models label Jul 11, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @b8zhong, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is a work-in-progress effort to integrate Expert Parallel Load Balancing (EPLB) capabilities into the Llama4 model within vLLM. My changes involve extending the model's architecture to support EPLB configuration, implementing a standardized interface for MoE management, and ensuring proper propagation of EPLB settings throughout the model's layers.

Highlights

  • Enable Expert Parallel Load Balancing (EPLB) for Llama4: I've introduced an enable_eplb boolean parameter across various Llama4 model components (Llama4MoE, Llama4DecoderLayer, Llama4Model) to control the activation of Expert Parallel Load Balancing. This flag is propagated from the top-level model configuration down to individual MoE layers.
  • MixtureOfExperts Interface Implementation: The Llama4ForCausalLM class now inherits from a new MixtureOfExperts interface. This involves implementing several properties (expert_weights, num_moe_layers, num_logical_experts, etc.) and methods (set_eplb_state, get_expert_weights) to provide a standardized way to query and manage the state of Mixture-of-Experts layers for EPLB.
  • MoE Layer Tracking and Management: I've added logic within Llama4Model and Llama4ForCausalLM to identify and track all Mixture-of-Experts (MoE) layers. This tracking is crucial for the MixtureOfExperts interface to correctly manage and expose information about the model's expert configuration and state for load balancing.
  • Dependency Updates and Model Layer Creation Override: I've added new imports for the MixtureOfExperts interface and PPMissingLayer from internal vLLM modules, indicating integration with existing MoE and pipeline parallelism infrastructure. Additionally, the make_layers method in Llama4Model has been overridden to ensure the enable_eplb parameter is correctly passed to the decoder layers during their creation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces changes to enable EPLB for the Llama4 model. The changes involve propagating an enable_eplb flag through the model's layers and implementing the MixtureOfExperts interface. There are opportunities for code improvement to enhance maintainability and correctness.

Copy link

mergify bot commented Jul 12, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @b8zhong.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Jul 12, 2025
@b8zhong b8zhong force-pushed the enable-llama4-eplb branch from 5891bdd to 8713349 Compare July 14, 2025 02:54
@mergify mergify bot removed the needs-rebase label Jul 14, 2025
@b8zhong b8zhong force-pushed the enable-llama4-eplb branch from 8713349 to 09f5096 Compare July 14, 2025 02:55
@mergify mergify bot added ci/build frontend rocm Related to AMD ROCm v1 tpu Related to Google TPUs labels Jul 14, 2025
@b8zhong b8zhong force-pushed the enable-llama4-eplb branch from 584d83f to 8ff94c6 Compare July 14, 2025 03:11
@mergify mergify bot added documentation Improvements or additions to documentation deepseek Related to DeepSeek models multi-modality Related to multi-modality (#4194) new-model Requests to new models performance Performance-related issues qwen Related to Qwen models structured-output speculative-decoding labels Jul 14, 2025
Copy link

mergify bot commented Jul 14, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @b8zhong.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot removed the needs-rebase label Jul 14, 2025
@b8zhong b8zhong closed this Jul 14, 2025
@b8zhong b8zhong force-pushed the enable-llama4-eplb branch from bb863f3 to 66f6fbd Compare July 14, 2025 03:16
@mergify mergify bot removed the tpu Related to Google TPUs label Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build deepseek Related to DeepSeek models documentation Improvements or additions to documentation frontend llama Related to Llama models multi-modality Related to multi-modality (#4194) new-model Requests to new models performance Performance-related issues qwen Related to Qwen models rocm Related to AMD ROCm speculative-decoding structured-output tool-calling v1
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants