Skip to content

[V0 deprecation] Removal V0 structured outputs #20928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

aarnphm
Copy link
Collaborator

@aarnphm aarnphm commented Jul 14, 2025

This PR is a continuation of removal for V0, starting with structured outputs

Signed-off-by: Aaron Pham contact@aarnphm.xyz

Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@aarnphm aarnphm added this to the v0.10.0 milestone Jul 14, 2025
@aarnphm aarnphm marked this pull request as ready for review July 14, 2025 15:18
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @aarnphm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request is a continuation of the effort to remove V0 features, specifically targeting structured output capabilities. It deprecates and removes the guided decoding functionality from the V0 engine, ensuring that users are directed towards the V1 engine for these advanced output controls. This change simplifies the codebase by removing legacy components and clarifies the supported feature set for different engine versions.

Highlights

  • Deprecation of V0 Structured Outputs: This pull request explicitly removes support for V0 structured outputs. Attempts to use guided_decoding parameters with the V0 engine will now raise a ValueError, directing users to switch to the V1 engine for this functionality.
  • Removal of Guided Decoding Logic: The core logic responsible for building guided decoding logits processors, including the build_guided_decoding_logits_processor_async function and related imports, has been removed from both vllm/engine/async_llm_engine.py and vllm/engine/multiprocessing/client.py.
  • Removal of Guided Decoding Tests: The test_mistral_guided_decoding function, which previously validated Mistral's guided decoding capabilities using JSON schema, has been removed from tests/models/language/generation/test_mistral.py, aligning with the deprecation of V0 structured outputs.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@aarnphm aarnphm added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 14, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR removes V0 structured outputs, replacing them with ValueErrors that guide users to V1. I've pointed out a minor typo in the new error messages.

Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aarnphm Thanks for doing this! Could you please check the CI failures?

@hmellor hmellor moved this to In Progress in V0 Deprecation Jul 18, 2025
@hmellor hmellor changed the title [Chore] Removal V0 structured outputs [V0 deprecation] Removal V0 structured outputs Jul 18, 2025
Copy link

mergify bot commented Jul 21, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @aarnphm.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@hmellor
Copy link
Member

hmellor commented Jul 29, 2025

Superseded by #21347

@hmellor hmellor closed this Jul 29, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in V0 Deprecation Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase ready ONLY add when PR is ready to merge/full CI is needed structured-output
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants