-
-
Notifications
You must be signed in to change notification settings - Fork 9k
[V0 deprecation] Removal V0 structured outputs #20928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @aarnphm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request is a continuation of the effort to remove V0 features, specifically targeting structured output capabilities. It deprecates and removes the guided decoding functionality from the V0 engine, ensuring that users are directed towards the V1 engine for these advanced output controls. This change simplifies the codebase by removing legacy components and clarifies the supported feature set for different engine versions.
Highlights
- Deprecation of V0 Structured Outputs: This pull request explicitly removes support for V0 structured outputs. Attempts to use
guided_decoding
parameters with the V0 engine will now raise aValueError
, directing users to switch to the V1 engine for this functionality. - Removal of Guided Decoding Logic: The core logic responsible for building guided decoding logits processors, including the
build_guided_decoding_logits_processor_async
function and related imports, has been removed from bothvllm/engine/async_llm_engine.py
andvllm/engine/multiprocessing/client.py
. - Removal of Guided Decoding Tests: The
test_mistral_guided_decoding
function, which previously validated Mistral's guided decoding capabilities using JSON schema, has been removed fromtests/models/language/generation/test_mistral.py
, aligning with the deprecation of V0 structured outputs.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR removes V0 structured outputs, replacing them with ValueErrors that guide users to V1. I've pointed out a minor typo in the new error messages.
Signed-off-by: Aaron Pham <contact@aarnphm.xyz>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aarnphm Thanks for doing this! Could you please check the CI failures?
This pull request has merge conflicts that must be resolved before it can be |
Superseded by #21347 |
This PR is a continuation of removal for V0, starting with structured outputs
Signed-off-by: Aaron Pham contact@aarnphm.xyz