-
-
Notifications
You must be signed in to change notification settings - Fork 11k
[Bugfix] Fix test fused quant layernorm tests #27865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ElizaWszola
wants to merge
6
commits into
vllm-project:main
Choose a base branch
from
neuralmagic:fix-fused-quant-layernorm-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Bugfix] Fix test fused quant layernorm tests #27865
ElizaWszola
wants to merge
6
commits into
vllm-project:main
from
neuralmagic:fix-fused-quant-layernorm-tests
+28
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ElizaWszola <ewszola@redhat.com>
Signed-off-by: yewentao256 <zhyanwentao@126.com>
Signed-off-by: yewentao256 <zhyanwentao@126.com>
yewentao256
reviewed
Nov 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After we fix the scale_ub case in unit test, we now face three known issues.
- precision error for int8
- precision error for fp8
- illegal memory access without setting scale_ub
And I fix all of them in my commits
reserve core]$ pytest test_fused_quant_layernorm.py -x
============= test session starts ==============
platform linux -- Python 3.12.11, pytest-8.4.2, pluggy-1.6.0
rootdir: /home/yewentao256/vllm-source
configfile: pyproject.toml
plugins: anyio-4.11.0
collected 576 items
test_fused_quant_layernorm.py .......... [ 1%]
........................................ [ 8%]
........................................ [ 15%]
........................................ [ 22%]
........................................ [ 29%]
........................................ [ 36%]
........................................ [ 43%]
........................................ [ 50%]
........................................ [ 57%]
........................................ [ 64%]
........................................ [ 71%]
........................................ [ 78%]
........................................ [ 85%]
........................................ [ 92%]
........................................ [ 98%]
...... [100%]
= 576 passed, 2 warnings in 160.03s (0:02:40) ==Signed-off-by: ElizaWszola <ewszola@redhat.com>
ElizaWszola
added a commit
to neuralmagic/vllm
that referenced
this pull request
Nov 4, 2025
…or int8 Signed-off-by: ElizaWszola <ewszola@redhat.com>
Signed-off-by: ElizaWszola <ewszola@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix optional vs. bool type issue in
test_fused_quant_layernorm.py. This allows int8 tests to run correctly.TODO: fix unit test failures