feat(validator): add isUrl() and isEmail() validators with tests #584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What Adds Validator::isUrl(int $flags = 0) and Validator::isEmail() to the fluent validation API. Why Many projects keep APP_URL, webhook endpoints, and support emails in .env. Validating these early prevents misconfiguration and runtime failures. Complements existing validators (isInteger(), isBoolean(), allowedValues()) described in the README. GitHub How Uses filter_var(..., FILTER_VALIDATE_URL|EMAIL) for correctness and maintainability; supports optional URL flags (e.g., FILTER_FLAG_PATH_REQUIRED). Honors required() vs ifPresent() semantics. Tests Added unit tests for pass/fail cases and ifPresent() interplay. Docs README: small usage snippet in Validation section. BC breaks None.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds Validator::isUrl(int $flags = 0) and Validator::isEmail() to the fluent validation API.
Why
Many projects keep APP_URL, webhook endpoints, and support emails in .env. Validating these early prevents misconfiguration and runtime failures. Complements existing validators (isInteger(), isBoolean(), allowedValues()) described in the README. GitHub
How
Uses filter_var(..., FILTER_VALIDATE_URL|EMAIL) for correctness and maintainability; supports optional URL flags (e.g., FILTER_FLAG_PATH_REQUIRED). Honors required() vs ifPresent() semantics.
Tests
Added unit tests for pass/fail cases and ifPresent() interplay.
Docs
README: small usage snippet in Validation section.
BC breaks
None.